Skip to content

fix(build): stamp release tag into BSD binary version #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjake merged 1 commit into from
Jul 24, 2026
Merged

fix(build): stamp release tag into BSD binary version #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions .github/workflows/build_unix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,11 @@ jobs:
# Upstream's vendor tree is already complete; trust it.
go mod download
go install golang.org/x/tools/cmd/goimports@latest
gmake cloudflared
# Stamp the release tag into the binary (main.Version). The build
# runs while the GitHub release is still a draft, so the git tag
# does not exist yet and the Makefile's `git describe` would fall
# back to a bare commit SHA. Passing VERSION explicitly overrides it.
gmake cloudflared VERSION="${{ steps.get_release.outputs.tag_name }}"

# Build step for NetBSD
- name: Build from Source on NetBSD
Expand Down Expand Up @@ -134,7 +138,11 @@ jobs:
# Upstream's vendor tree is already complete; trust it.
go mod download
go install golang.org/x/tools/cmd/goimports@latest
gmake cloudflared
# Stamp the release tag into the binary (main.Version). The build
# runs while the GitHub release is still a draft, so the git tag
# does not exist yet and the Makefile's `git describe` would fall
# back to a bare commit SHA. Passing VERSION explicitly overrides it.
gmake cloudflared VERSION="${{ steps.get_release.outputs.tag_name }}"

# Build step for OpenBSD
- name: Build from Source on OpenBSD
Expand All @@ -156,7 +164,11 @@ jobs:
# Upstream's vendor tree is already complete; trust it.
go mod download
go install golang.org/x/tools/cmd/goimports@latest
gmake cloudflared
# Stamp the release tag into the binary (main.Version). The build
# runs while the GitHub release is still a draft, so the git tag
# does not exist yet and the Makefile's `git describe` would fall
# back to a bare commit SHA. Passing VERSION explicitly overrides it.
gmake cloudflared VERSION="${{ steps.get_release.outputs.tag_name }}"

- name: Authenticate GH CLI
run: echo "${{ secrets.GITHUB_TOKEN }}" | gh auth login --with-token
Expand Down