Skip to content

Enhance and document SASL support #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Kufat wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Enhance and document SASL support #359

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fcc0c0
Add atheme SASL AUTHCOOKIE support
Kufat May 28, 2023
b388628
Add callback and authc/zid support, document
Kufat May 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/commands/handlers/registration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ const handlers = {
const saslAuth = getSaslAuth(handler);
const auth_str = saslAuth.account + '\0' +
saslAuth.account + '\0' +
saslAuth.password;
saslAuth.secret;
const b = Buffer.from(auth_str, 'utf8');
const b64 = b.toString('base64');

Expand Down Expand Up @@ -437,7 +437,9 @@ function getSaslAuth(handler) {
// An account username has been given, use it for SASL auth
return {
account: options.account.account,
password: options.account.password || '',
secret: (options.sasl_mechanism.toUpperCase() === 'AUTHCOOKIE' ?
Comment thread
Kufat marked this conversation as resolved.
Outdated
options.account.authcookie :
Comment thread
Kufat marked this conversation as resolved.
Outdated
options.account.password) || '',
};
} else if (options.account) {
// An account object existed but without auth credentials
Expand All @@ -447,7 +449,7 @@ function getSaslAuth(handler) {
// for ease of use
return {
account: options.nick,
password: options.password,
secret: options.password,
};
}

Expand Down