Skip to content

selftests/bpf: Track test_xdp_features DUT processes - #13225

Open
kernel-patches-daemon-bpf[bot] wants to merge 1 commit into
bpf-next_basefrom
series/1144562=>bpf-next
Open

selftests/bpf: Track test_xdp_features DUT processes#13225
kernel-patches-daemon-bpf[bot] wants to merge 1 commit into
bpf-next_basefrom
series/1144562=>bpf-next

Conversation

@kernel-patches-daemon-bpf

@kernel-patches-daemon-bpf kernel-patches-daemon-bpf Bot commented Aug 12, 2026

Copy link
Copy Markdown

Pull request for series with
subject: selftests/bpf: Track test_xdp_features DUT processes
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 12, 2026

Copy link
Copy Markdown
Author

Upstream branch: 07cb86a
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-review-bot

kernel-patches-review-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown 
commit d3db51eaebd248a6a61e7383cb8dd2af28c22d16
Author: Bochao Cao <bochaolucky@gmail.com>

selftests/bpf: Track test_xdp_features DUT processes

This commit fixes race conditions in test_xdp_features.sh where concurrent
tests could interfere with each other due to shared pidof lookups, and adds
timeout handling for DUT readiness checks.

Closes: https://bugs.debian.org/1136522

> diff --git a/tools/testing/selftests/bpf/test_xdp_features.sh b/tools/testing/selftests/bpf/test_xdp_features.sh
> index 0aa71c4455c0..35ce0d4e2418 100755
> --- a/tools/testing/selftests/bpf/test_xdp_features.sh
> +++ b/tools/testing/selftests/bpf/test_xdp_features.sh

[ ... ]

> +terminate_dut_server() {
> +	[ -z "$dut_pid" ] && return
> +
> +	# Use the shell job instead of a PID which may have been reused.
> +	if [ "$(jobs -pr %% 2> /dev/null)" = "$dut_pid" ]; then
> +		kill -KILL %% 2> /dev/null || true
> +	fi
> +
> +	wait "$dut_pid" 2> /dev/null || true
> +	dut_pid=""
> +}
> +
>  cleanup() {
> -	ip link del v1 2> /dev/null
> -	ip netns del ${NS} 2> /dev/null
> -	[ "$(pidof xdp_features)" = "" ] || kill $(pidof xdp_features) 2> /dev/null
> +	terminate_dut_server
> +	ip link del v1 2> /dev/null || true
> +	ip netns del "${NS}" 2> /dev/null || true
>  }

Jiayuan Chen asked about removing the pidof dependency in v1: "It looks like
part of the motivation here is dropping the pidof dependency? I don't think
that's worth optimizing. Selftests already require a bunch of tools from
non-essential packages (ip, ss and ethtool in this very script)". Does the
removal of pidof serve another purpose beyond reducing dependencies, such as
fixing the concurrent test interference described in the commit message? If
the primary goal is fixing the race condition rather than removing a
dependency, it might be worth clarifying the motivation.

AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

In-Reply-To-Subject: selftests/bpf: Track test_xdp_features DUT processes
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/31579454720

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 12, 2026

Copy link
Copy Markdown
Author

Forwarding comment 5264730219 via email
In-Reply-To: 20260812-xdp-dut-process-lifecycle-gmail-v2-1-b03ef2aa1b97@gmail.com
Patch: https://patchwork.kernel.org/project/netdevbpf/patch/20260812-xdp-dut-process-lifecycle-gmail-v2-1-b03ef2aa1b97@gmail.com/

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 12, 2026

Copy link
Copy Markdown
Author

Upstream branch: 611a9f0
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 12, 2026

Copy link
Copy Markdown
Author

Upstream branch: 3a59f11
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 12, 2026

Copy link
Copy Markdown
Author

Upstream branch: 3a59f11
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 13, 2026

Copy link
Copy Markdown
Author

Upstream branch: 108d440
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 13, 2026

Copy link
Copy Markdown
Author

Upstream branch: a88dbe1
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 13, 2026

Copy link
Copy Markdown
Author

Upstream branch: 7c3e54c
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 16, 2026

Copy link
Copy Markdown
Author

Upstream branch: c93cbdb
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: 8eb1892
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: d99bda7
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: 34e0eb7
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: 5fe7007
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: 77877bf
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: adb7719
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: 6b0835a
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: 6ab6a94
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: 3d9393f
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: f79066c
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Upstream branch: 91ec203
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Upstream branch: aed1bf1
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 20, 2026

Copy link
Copy Markdown
Author

Upstream branch: d19862d
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 21, 2026

Copy link
Copy Markdown
Author

Upstream branch: 4191e49
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 21, 2026

Copy link
Copy Markdown
Author

Upstream branch: 4954de7
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 21, 2026

Copy link
Copy Markdown
Author

Upstream branch: e40f61a
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 21, 2026

Copy link
Copy Markdown
Author

Upstream branch: 669e4fa
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 23, 2026

Copy link
Copy Markdown
Author

Upstream branch: a284ed4
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 23, 2026

Copy link
Copy Markdown
Author

Upstream branch: 5e289c5
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

1 similar comment
@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 23, 2026

Copy link
Copy Markdown
Author

Upstream branch: 5e289c5
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 25, 2026

Copy link
Copy Markdown
Author

Upstream branch: d83fba2
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 25, 2026

Copy link
Copy Markdown
Author

Upstream branch: ce36e38
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 25, 2026

Copy link
Copy Markdown
Author

Upstream branch: 05ea1b6
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 25, 2026

Copy link
Copy Markdown
Author

Upstream branch: 1555de3
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@kernel-patches-daemon-bpf

kernel-patches-daemon-bpf Bot commented Aug 26, 2026

Copy link
Copy Markdown
Author

Upstream branch: 48b69cc
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1144562
version: 2

@bochaolucky Kernel Patches Daemon
selftests/bpf: Track test_xdp_features DUT processes
8ca2a1a 
test_xdp_features.sh waits for any xdp_features listener to appear and
uses pidof during cleanup. A concurrent test can therefore make another
test proceed before its own DUT is ready, and cleanup kills every
xdp_features process on the host. The readiness loop also has no timeout,
so a DUT that exits before listening leaves the test hung indefinitely.

Track one active DUT at a time, wait for ss to report that exact PID with
a bounded retry loop, and reap it after each test. Consult the shell job
table before signaling the DUT so a stale PID cannot target an unrelated
process. On failure, terminate the shell job with SIGKILL and reap it so
blocked I/O cannot hang cleanup. Install an EXIT trap and signal handlers
so failure paths also remove network setup.

Fixes: 4dba3e7 ("selftests/bpf: introduce XDP compliance test tool")
Closes: https://bugs.debian.org/1136522
Signed-off-by: Bochao Cao <bochaolucky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bpf-next needs-ack V2-ci-pass V2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bochaolucky