feat(icon): add custom action icon - #688
Open
ricardogoncalves89 wants to merge 2 commits into
Open
ricardogoncalves89 wants to merge 2 commits into
ricardogoncalves89 wants to merge 2 commits into
Conversation
djcouto
approved these changes
Sep 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
custom-actionicon to the icon library so it can be used across Kelvin apps viaEIconName.CustomAction, and fixes selected tab-item styling so a selected tab keeps its selected appearance while hovered.Changes
kv-custom-actionsymbol topackages/ui-components/src/assets/svg-symbols.svg(24×24 viewBox, single-path glyph).CustomAction = 'kv-custom-action'inEIconName(packages/ui-components/src/components/icon/icon.types.ts) so the icon is selectable throughkv-icon/KvIcon.:not(:hover)guard from the.selectedrules intab-item.scssso a selected tab (secondary and icon variants) keeps its selected background/border on hover, and unset the pointer cursor on the selected tab since clicking it is a no-op.Test Plan
pnpm build:packagespnpm lintpnpm storybook; in the Icon story verifykv-custom-actionrenders in both light and night modes, and in the Tabs stories hover a selected tab and confirm it keeps the selected background and shows the default cursor.