Skip to content

SUP-52393: Prevent automatic caption requests after manual CaptionAss… #14095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlaaSaf12 merged 3 commits into from
Aug 3, 2026
+5 −0
Merged

SUP-52393: Prevent automatic caption requests after manual CaptionAss… #14095

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
707cae5
SUP-52393: Prevent automatic caption requests after manual CaptionAss…
Jul 29, 2026
4123a42
SUP-52393: remove duplicate code,fixing moshi comment
Aug 3, 2026
3c1b2d3
add { on new line
AlaaSaf12 Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions plugins/reach/lib/kReachManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,12 @@ private function addingEntryVendorTaskByObjectIds($taskObjectType, $allowedCata

private function shouldSkipAutoRule($object, $entryId, $featureType)
{
if ($object instanceof CaptionAsset && $featureType == VendorServiceFeature::CAPTIONS)
Comment thread
AlaaSaf12 marked this conversation as resolved.
Outdated
{
KalturaLog::log("Skip automatic caption rule triggered by a CaptionAsset upload for entry [$entryId]");
return true;
}

if ($featureType == VendorServiceFeature::CAPTIONS)
{
if ($object instanceof entry && $object->getBlockAutoTranscript())
Expand Down
Loading