PLAT-26004: drm key management policy set from drop folder xml upload… - #14089
Merged
Conversation
… flow and distribution
|
@github-copilot suggest |
| <xs:appinfo> | ||
| <example> | ||
| <drmConfiguration> | ||
| <keyManagementPolicy>3</keyManagementPolicy> |
| if ($objectType == KeyManagementPolicyObjectType::PARTNER) | ||
| { | ||
| $partner = $this->getValidatedPartner($objectId); | ||
| $partner->setDrmKeyManagementPolicy($keyManagementPolicy->keyManagementPolicy); |
Collaborator
There was a problem hiding this comment.
on this branch case, you still need to validate the propert they are trying to set as the partner policy is not null (0 explicitly should be allowed)
| protected function setDrmKeyManagementPolicyForEntry(entry $entry, KalturaKeyManagementPolicy $keyManagementPolicy) | ||
| { | ||
| $partner = $entry->getPartner(); | ||
| $partnerDrmKeyManagementPolicy = $partner->getDrmKeyManagementPolicy(); |
Collaborator
There was a problem hiding this comment.
add null check before refferencing the partner
inbal-ben-david
approved these changes
Aug 3, 2026
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… flow and distribution
Pull Request Checklist
Please complete the following before submitting:
General notes -
New Kaltura Types
New Kaltura Services / Actions
Questions
What is the purpose of this PR?
Does this change affect production code or infrastructure?
If yes, what is the rollback plan?