Security: Enforce security.ini by default via KCurlWrapper (control hardening) - #13907
Draft
MosheMaorKaltura with Copilot wants to merge 1 commit into
Draft
Security: Enforce security.ini by default via KCurlWrapper (control hardening)#13907MosheMaorKaltura with Copilot wants to merge 1 commit into
MosheMaorKaltura with Copilot wants to merge 1 commit into
Conversation
…ardening) Agent-Logs-Url: https://github.com/kaltura/server/sessions/b5d44fe2-2d9e-47f7-a113-9fdc3edbb2e3 Co-authored-by: MosheMaorKaltura <10695851+MosheMaorKaltura@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
MosheMaorKaltura
April 14, 2026 09:34
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please complete the following before submitting:
General notes -
New Kaltura Types
New Kaltura Services / Actions
Questions
What is the purpose of this PR?
KCurlWrapper::isWhiteListedInternalUrl()to deny internal URLs by default whensecurity.iniis not configured. Previously, missing config meant all internal URLs were allowed (permissive default). Now enforces deny-by-default.Does this change affect production code or infrastructure?
If yes, what is the rollback plan?
infra/general/KCurlWrapper.class.php(line 725:return false→return true). Alternatively, ensuresecurity.iniis deployed with appropriateinternal_url_whitelistpatterns before rollout.Change Summary
Before:
After:
Affects both
KCurlWrapperandKAxelWrapper(which extends it). Internal URL access now requires explicit whitelisting insecurity.ini.