fix(SUP-50789): Fix Sync Method Used Credit - #13889
Open
yambenari24 wants to merge 3 commits into
Open
Conversation
|
@github-copilot suggest |
shahbaa123
reviewed
Apr 9, 2026
| $queueC->add(EntryVendorTaskPeer::PRICE, 0, Criteria::NOT_EQUAL); | ||
| $queueC->add(EntryVendorTaskPeer::STATUS, [EntryVendorTaskStatus::PENDING, EntryVendorTaskStatus::PROCESSING, EntryVendorTaskStatus::READY], Criteria::IN); | ||
| $queueC->add(EntryVendorTaskPeer::QUEUE_TIME, $syncStartDate, Criteria::GREATER_EQUAL); | ||
|
|
Collaborator
There was a problem hiding this comment.
why this $this->addAdditionalCriteria($c); was deleted?
shahbaa123
reviewed
Apr 9, 2026
| { | ||
| $totalUsedCredit += $totalPrice; | ||
| } | ||
| return $totalUsedCredit; |
Collaborator
There was a problem hiding this comment.
why deleted these 2 lines?
$this->setSyncedCredit($totalUsedCredit);
$this->setLastSyncTime($now);
shahbaa123
reviewed
Apr 9, 2026
| if ($dbVendorCatalogItem) | ||
| { | ||
| $object_to_fill->setIsPayPerUse($dbVendorCatalogItem->getPayPerUse()); | ||
| } |
Collaborator
There was a problem hiding this comment.
I think it is better to add Default value to the setIsPayPerUse
else
{
$object_to_fill->setIsPayPerUse(false); // Default value
}
@MosheMaorKaltura WDYT?
|
@github-copilot suggest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please complete the following before submitting:
General notes -
New Kaltura Types
New Kaltura Services / Actions
Questions
What is the purpose of this PR?
Does this change affect production code or infrastructure?
If yes, what is the rollback plan?