fix: archive a parked question before its reply - #2616
Merged
Conversation
An agent that stops to ask something parks the task with the question in its `status`, not in its history. Answering replaces that status, and the store writes down the messages each event names rather than the history of the task it is handed — so the question was written nowhere and vanished from the transcript on the next read. The copy still on screen was then appended below the answer it preceded, because a merge keeps what the server did not send. The question is now stored in its own right, and before the reply, because history is ordered by insertion. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
github-actions
Bot
added
bug
github-actions
Bot
added
bug
Charlesthebird
marked this pull request as ready for review
August 28, 2026 15:00
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
EItanya
approved these changes
Aug 28, 2026
| t.Fatalf("reply result = %#v, runtime sent = %v", result, runtime.sent) | ||
| } | ||
| if authorizer.verb != auth.VerbUpdate || reply.ContextID != gatewayTestID || len(store.stored) != 2 { | ||
| // Three: the question the task was parked on, the reply, and the finished turn. |
Collaborator
Author
There was a problem hiding this comment.
haha yeah I don't know
Collaborator
Author
There was a problem hiding this comment.
it might've been some checklist item it was talking about to itself.
but I tested it after your changes and it's still working - thanks for updating it!
EItanya
added a commit
that referenced
this pull request
Aug 28, 2026
Follow-up to #2616. Documents the invariant that state and history for one logical transition must be computed before persistence and committed in one store transaction. It also keeps preparatory writes out of transport code and requires malformed durable data to be rejected. Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before there was a bug where the agent question disappears from the chat:
Screen.Recording.2026-08-28.at.10.11.50.AM.mov
After, this is now stable across refreshes:
Screen.Recording.2026-08-28.at.10.56.34.AM.mov
🤖 written by Claude (start)
Changelog
An agent's question no longer disappears from the transcript once you answer it: a parked task holds the question in its status, which the reply replaces, so it is now archived as history first.
Testing
🤖 written by Claude (end)