containerprofile: let one annotation follow the newest report - #49
Merged
Merged
Conversation
Chunk annotations fold into the consolidated profile first-write-wins, which freezes every key at whatever the first chunk carried. kubescape.io/timeline is a running record the agent rewrites in full on every chunk, so the value whose last entry is the latest wins, independent of the order chunks are merged in. An empty or unparsable value never replaces a parsable one; every other annotation keeps first-write-wins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chunk annotations fold into the consolidated ContainerProfile first-write-wins, so every key freezes at whatever the first chunk carried.
kubescape.io/timelineis a running record the agent rewrites in full on every chunk; this exempts that one key and keeps the value whose last entry is the latest, independent of merge order. Empty or unparsable values never replace a parsable one. Every other annotation keeps first-write-wins.Tests:
TestNewerTimeline(table),TestMergeContainerProfileTS_TimelineIsOrderIndependent(both merge orders),_TimelineAcrossBatches,_TimelineOnNilAnnotations,_OtherAnnotationsStayFirstWriteWins. The order-independence test fails on the previous assign-in-order form.