Skip to content

Fix workspace dependencies, improve integrity script - #8010

Draft
jtpio wants to merge 4 commits into
jupyter:mainfrom
jtpio:fix-workspace-dependencies
Draft

Fix workspace dependencies, improve integrity script#8010
jtpio wants to merge 4 commits into
jupyter:mainfrom
jtpio:fix-workspace-dependencies

Conversation

@jtpio

@jtpio jtpio commented Jul 31, 2026

Copy link
Copy Markdown
Member

References

Trying to follow the approach used in JupyterLab (mostly in @jupyterlab/buildutils) to ensure a more consistent code base via the integrity check.

Code changes

  • Fix import consistencies between dependencies and what gets used, per package
  • Generate style files automatically

User-facing changes

None

Backwards-incompatible changes

None

@jtpio jtpio added this to the 7.7.0 milestone Jul 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/fix-workspace-dependencies

@jtpio
jtpio force-pushed the fix-workspace-dependencies branch from 80faa4b to 00cdded Compare August 17, 2026 17:04
@jtpio
jtpio requested a balanced review from Copilot August 17, 2026 19:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns workspace metadata with actual imports and expands integrity checks to generate consistent package styles and metadata.

Changes:

  • Validates package dependencies, versions, TypeScript references, and root lint dependencies.
  • Automatically generates package style entry points and documentation headers.
  • Updates manifests, lockfile, and CI integrity enforcement.

Reviewed changes

Copilot reviewed 61 out of 62 changed files in this pull request and generated no comments.

Show a summary per file
File Description
yarn.lock Synchronizes resolved workspace dependencies.
packages/ui-components/tsconfig.json Adds generated project references.
packages/ui-components/style/index.js Marks generated style module.
packages/ui-components/style/index.css Marks generated CSS entry.
packages/ui-components/src/index.ts Adds package documentation.
packages/ui-components/package.json Corrects dependencies and packaged sources.
packages/tree/tsconfig.json Adds generated project references.
packages/tree/style/index.js Generates style module imports.
packages/tree/style/index.css Generates CSS imports.
packages/tree/src/index.ts Adds package documentation.
packages/tree/package.json Removes unused dependencies and files.
packages/tree-extension/style/index.js Generates style module imports.
packages/tree-extension/style/index.css Generates CSS imports.
packages/tree-extension/src/index.ts Adds package documentation.
packages/tree-extension/package.json Aligns dependencies with imports.
packages/terminal-extension/style/index.js Generates style module entry.
packages/terminal-extension/style/index.css Generates CSS entry.
packages/terminal-extension/src/index.ts Adds package documentation.
packages/terminal-extension/package.json Includes source files.
packages/notebook-extension/style/index.js Generates dependency style imports.
packages/notebook-extension/style/index.css Generates dependency CSS imports.
packages/notebook-extension/src/index.ts Adds package documentation.
packages/notebook-extension/package.json Aligns dependencies with imports.
packages/lab-extension/style/index.js Generates style module entry.
packages/lab-extension/style/index.css Generates CSS entry.
packages/lab-extension/src/index.ts Adds package documentation.
packages/lab-extension/package.json Updates build and package metadata.
packages/help-extension/style/index.js Generates style module entry.
packages/help-extension/style/index.css Generates CSS entry.
packages/help-extension/src/index.tsx Adds package documentation.
packages/help-extension/package.json Removes unused React DOM dependency.
packages/documentsearch-extension/style/index.js Generates style module entry.
packages/documentsearch-extension/style/index.css Generates CSS entry.
packages/documentsearch-extension/src/index.ts Adds package documentation.
packages/documentsearch-extension/package.json Removes nonexistent schema metadata.
packages/docmanager-extension/style/index.js Generates style module entry.
packages/docmanager-extension/style/index.css Generates CSS entry.
packages/docmanager-extension/src/index.ts Adds package documentation.
packages/docmanager-extension/package.json Removes unused dependencies.
packages/console-extension/style/index.js Generates style module entry.
packages/console-extension/style/index.css Generates CSS entry.
packages/console-extension/src/index.ts Adds package documentation.
packages/console-extension/package.json Includes source files.
packages/application/tsconfig.json Adds generated project references.
packages/application/style/index.js Generates dependency style imports.
packages/application/style/index.css Generates dependency CSS imports.
packages/application/style/base.css Incorporates side-panel styles.
packages/application/src/index.ts Adds package documentation.
packages/application/package.json Adds imported dependencies and sources.
packages/application-extension/style/index.js Generates style module imports.
packages/application-extension/style/index.css Generates CSS imports.
packages/application-extension/src/index.ts Adds package documentation.
packages/application-extension/package.json Removes unused dependency.
packages/_metapackage/style/index.js Aggregates workspace style modules.
packages/_metapackage/style/index.css Aggregates workspace CSS.
packages/_metapackage/src/index.ts Adds package documentation.
packages/_metapackage/package.json Exposes aggregate style entries.
package.json Declares the ESLint JSON parser.
buildutils/src/ensure-repo.ts Implements comprehensive integrity validation.
buildutils/package.json Adds dependency graph support.
app/package.json Declares directly used build dependencies.
.github/workflows/build.yml Enforces integrity checks in CI.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants