Add top-level permissions blocks to release workflows - #7942
Open
goelakash wants to merge 1 commit into
Open
Conversation
The three release workflows (prep-release, publish-release, publish-changelog) had no top-level permissions block, so jobs inherited the broad workflow default. Adds an explicit top-level `permissions: contents: read` (least-privilege default), and a job-level read in publish-changelog since the actual write goes through the GitHub App token, not GITHUB_TOKEN. Improves the OpenSSF Scorecard Token-Permissions check, currently 0/10 (https://scorecard.dev/viewer/?uri=github.com%2Fjupyter%2Fnotebook). Refs jupyter#7941
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The three release workflows (
prep-release,publish-release,publish-changelog) had no top-levelpermissionsblock, so jobs inherited the broad workflow default. Adds an explicitpermissions: contents: readat the top of each (least-privilege default).publish-changelogalso gets a matching job-level read since the actual write goes through the GitHub App token, notGITHUB_TOKEN.Improves the OpenSSF Scorecard
Token-Permissionscheck, currently 0/10:https://scorecard.dev/viewer/?uri=github.com%2Fjupyter%2Fnotebook
Refs #7941