feat: open api ports from config reconciliation - #145
Open
ale8k wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The controller application (jujud-controller) is the workload managed by this charm, so its externally reachable ports are a property of the charm rather than of Juju's controller config (as expressed by @SimonRichardson in this PR).
This adds charm config for the controller's ports and opens them via the charm, which lets operators restrict access with juju expose --to-cidrs which is something that isn't possible while the ports are opened by Juju's internal hardcoded firewall rules.
This is the charm side of the wider work to move controller port management out of Juju's hardcoded rules and onto the controller charm. There will be follow up work on the juju side will feed these config values at bootstrap, expose the controller app by default, have jujud read its ports from the charm, and remove the old hardcoded rules.