Share prepared analysis ownership for queries - #633
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jonathanong
force-pushed
the
agent-prepared-ownership
branch
from
August 9, 2026 23:50
2368850 to
47ea7de
Compare
jonathanong
marked this pull request as ready for review
August 10, 2026 15:47
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/no-mistakes/src/fetches/tests/run_with_base_root_tests.rs`:
- Around line 59-84: Strengthen
prepared_fetch_run_reuses_the_session_for_target_matching_and_traversal by
asserting the session work snapshot contains the fixture’s expected two
normalized source-read and parse-attempt entries before checking each count is
1. Also assert that the report includes the expected /api/users fetch result,
ensuring the test detects bypassed session reads, parsing, or traversal
regressions.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 5760397c-a877-42de-bf9c-fd4a96d260e3
📒 Files selected for processing (14)
crates/no-mistakes/src/codebase/ts_source/tests/gitignore.rscrates/no-mistakes/src/data_pw_query.rscrates/no-mistakes/src/data_pw_query/scan.rscrates/no-mistakes/src/data_pw_query/tests.rscrates/no-mistakes/src/fetch/file_analysis.rscrates/no-mistakes/src/fetch/file_facts.rscrates/no-mistakes/src/fetch/import_routes.rscrates/no-mistakes/src/fetch/mod.rscrates/no-mistakes/src/fetch/route_analysis.rscrates/no-mistakes/src/fetches/pipeline/route_analysis.rscrates/no-mistakes/src/fetches/pipeline/run.rscrates/no-mistakes/src/fetches/tests/run_with_base_root_tests.rscrates/no-mistakes/src/registry_extension_query.rscrates/no-mistakes/src/registry_extension_query/tests.rs
jonathanong
dismissed
coderabbitai[bot]’s stale review
August 10, 2026 16:09
Memoized registry-extension reports in the request session and strengthened the fetch session regression assertions.
jongleberry-bot
marked this pull request as draft
August 10, 2026 16:15
jonathanong
marked this pull request as ready for review
August 10, 2026 16:58
This comment has been minimized.
This comment has been minimized.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Routes data-pw, registry-extension, and fetches through one request-owned
AnalysisSession.Why
These public paths previously created independent inventories, source reads, or parse passes. The request boundary now owns visible files,
SourceStore, parsing, and the query-owned registry report projection.Impact
DashMap; only same-key builds coordinate throughOnceLockValidation
cargo clippy -p no-mistakes --all-targets --all-features -- -D warningscargo fmt --checkgit diff --checkShepherd Journal
AnalysisSessionmust itself memoize repeated query work. The per-key request-owned report projection fixes the behavior while preserving the unconditional regression.