Fail-closed Manim beat sync, required pacing, pipeline retime (#56) - #58
Merged
Merged
Conversation
Address #56 semantic sync failures: 1. Label→wait_word matching is fail-closed (no fuzzy containment, no leftover LLM wait_word indices when the label is unspoken). 2. When timing.json has words, every story box must resolve wait_word or explicitly set pace: none — compile/generate fail otherwise. 3. generate-all / rebuild-after-audio retime-compile existing animations/specs/*.scene.yaml after timestamps (optional --regen-scene-specs for OpenAI). 4. scene-compile --all --retime for offline wait_word rewrite. Co-authored-by: John Menke <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
August 1, 2026 11:28
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the semantic sync gap from #56: composed length could pass while boxes raced ahead or latched onto the wrong spoken words.
wait_wordis fail-closed: stem/exact (+ hyphen splits) only; no fuzzy containment; never keep leftover LLM indices for unmatched labelstiming.jsonhas words, every story box needs a matchedwait_wordor explicitpace: nonegenerate-all/rebuild-after-audio: timestamps → scene retime (existing specs) → images → Manim.--regen-scene-specsfor OpenAIdocgen scene-compile --all --retimeoffline rewrite of indicesConsumer workflow
docgen tts docgen timestamps docgen scene-compile --all --retime # or: generate-all (retimes automatically) docgen manim docgen composeUnmatched labels fail with a clear error — fix the spoken phrase in the spec, or set
pace: nonefor decorative boxes.Test plan
pytest tests/(299 passed)ruff check src/ tests/pace: nonescene-compile --all --retime→ Manim → compose