Skip to content

[codex] Encapsulate core service implementations - #208

Merged
jkendall327 merged 1 commit into
mainfrom
codex-internal-seal-core-classes
May 31, 2026
Merged

jkendall327 merged 1 commit into
mainfrom
codex-internal-seal-core-classes

Conversation

@jkendall327

Copy link
Copy Markdown
Owner

Summary

Moves Core-owned service and channel registration into Octans.Core, then narrows a broad set of implementation classes from public to internal sealed while leaving public contracts, DTOs, options, and UI-facing services available.

The client now depends on public abstractions for downloader discovery, import jobs, queries, and subscriptions where that let concrete Core implementations become internal.

Validation

  • dotnet test
  • git diff --check

Note: one full dotnet test run initially hit a transient DownloadTelemetryTests.RecordDownloadCompleted_EmitsHostScopedOutcomeMetrics metric-listener assertion; the targeted test passed immediately afterward, and the full suite then passed.

@jkendall327
jkendall327 marked this pull request as ready for review May 31, 2026 09:52
@jkendall327
jkendall327 merged commit 92c35bf into main May 31, 2026
1 check passed
@jkendall327
jkendall327 deleted the codex-internal-seal-core-classes branch May 31, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant