Repository navigation
Refactor SignalRSessionGateway to avoid circular dependency - #120
google-labs-jules[bot] wants to merge 1 commit into
Conversation
…dependency. - Introduced `OnSessionReconnected` event in `ISessionGateway`. - Refactored `SignalRSessionGateway` to trigger the event instead of manually dispatching messages. - Updated `PlayerLoginService` to listen for `OnSessionReconnected` and handle message sending. - Removed unused dependencies and logic from `SignalRSessionGateway`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Refactored the message dispatch logic in
SignalRSessionGatewayto resolve a circular dependency issue. Introduced anOnSessionReconnectedevent inISessionGatewaywhich is triggered upon player reconnection.PlayerLoginServicenow subscribes to this event and handles sending the welcome messages, allowingSignalRSessionGatewayto be decoupled from message generation and emission logic.PR created automatically by Jules for task 4081842950735543762 started by @jkendall327