feat: add syntax highlighting to code blocks - #85
Open
navahas wants to merge 1 commit into
Open
Conversation
Migrate parsing from markdown-rs to Comrak and highlight code blocks with Syntect. Comrak parses to an AST and exposes a codefence highlighter hook, so highlighting happens during rendering. - Replace markdown-rs with Comrak, preserving GFM, frontmatter, and raw HTML passthrough. - Add a custom SyntectAdapter; mermaid and unknown languages pass through untouched, keeping the language-mermaid marker. - Emit CSS classes (not inline colors), scoped per theme, so code restyles on theme switch with no re-render.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24.
Highlights fenced code blocks server-side with Syntect.
To do this cleanly, parsing moves from markdown-rs to Comrak. Comrak
exposes a code-block hook, so highlighting happens while the AST renders
instead of by scraping the generated HTML afterwards.
Highlighting emits CSS classes, not inline colors, and the class styles
are scoped per theme. That way one pre-rendered copy of the HTML serves
all themes and theme switching stays client-side. Mermaid and unknown
languages pass through untouched.
GFM, frontmatter, and raw HTML passthrough are preserved. syntect is
pure Rust (no C toolchain); the trade-off is a larger binary from its
bundled syntax/theme data.