Skip to content

Windows agents connected to Jenkins by SSH hang when cloning an SSH repo from github.com #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akash-manna-sky wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Windows agents connected to Jenkins by SSH hang when cloning an SSH repo from github.com #1716

Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
be15886
Prefer MinGit ssh over system OpenSSH on Windows, keeping OpenSSH as …
akash-manna-sky Dec 18, 2025
0323d28
Enhance SSH command options for improved security by adding BatchMode…
akash-manna-sky Dec 18, 2025
135b8a2
apply mvn spotless:apply
akash-manna-sky Dec 18, 2025
9981442
Refactor ssh executable search logic to prioritize system PATH check
akash-manna-sky Dec 18, 2025
9f33791
Enhance SSH command options by adding -n flag to prevent reading from…
akash-manna-sky Dec 27, 2025
4ed6db8
Enhance SSH command options by adding StrictHostKeyChecking for impro…
akash-manna-sky Dec 27, 2025
227f469
Remove StrictHostKeyChecking option from SSH command for improved fle…
akash-manna-sky Dec 28, 2025
0c26ea2
Merge branch 'master' into JENKINS-1715
akash-manna-sky Aug 15, 2026
d9a3ba4
Refactor environment variable handling in CliGitAPIImpl and add tests…
akash-manna-sky Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2626,6 +2626,15 @@
return sshexe;
}

// Check for ssh.exe on the system PATH (supports Microsoft OpenSSH and other alternate implementations)
String sshPath = getPathToExe("ssh");
if (sshPath != null) {
sshexe = new File(sshPath);
if (sshexe.exists()) {
return sshexe;

Check warning on line 2634 in src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered lines 

Lines 2630-2634 are not covered by tests
}
}

// Check Program Files
sshexe = getFileFromEnv("ProgramFiles", "\\Git\\bin\\ssh.exe");
if (sshexe != null && sshexe.exists()) {
Expand Down Expand Up @@ -2701,7 +2710,8 @@
w.write("setlocal enabledelayedexpansion");
w.newLine();
w.write("\"" + sshexe.getAbsolutePath()
+ "\" -i \"!JENKINS_GIT_SSH_KEYFILE!\" -l \"!JENKINS_GIT_SSH_USERNAME!\" "
+ "\" -n -T -i \"!JENKINS_GIT_SSH_KEYFILE!\" -l \"!JENKINS_GIT_SSH_USERNAME!\" "
+ "-o BatchMode=yes -o PasswordAuthentication=no -o StrictHostKeyChecking=yes "
Comment thread
MarkEWaite marked this conversation as resolved.
Outdated
+ getHostKeyFactory().forCliGit(listener).getVerifyHostKeyOption(knownHosts) + " %* ");
w.newLine();
}
Expand All @@ -2724,7 +2734,8 @@
w.newLine();
w.write("fi");
w.newLine();
w.write("ssh -i \"$JENKINS_GIT_SSH_KEYFILE\" -l \"$JENKINS_GIT_SSH_USERNAME\" "
w.write("ssh -n -T -i \"$JENKINS_GIT_SSH_KEYFILE\" -l \"$JENKINS_GIT_SSH_USERNAME\" "
+ "-o BatchMode=yes -o PasswordAuthentication=no -o StrictHostKeyChecking=yes "
Comment thread
MarkEWaite marked this conversation as resolved.
Outdated
+ getHostKeyFactory().forCliGit(listener).getVerifyHostKeyOption(knownHosts) + " \"$@\"");
w.newLine();
}
Expand Down
Loading