Repository navigation
Test: the chat box's name fits on any runner - #22
Merged
Merged
Conversation
a_long_message_wraps… asserted the chat box's edge names the machine at 44 columns, with the machine's real name. The edge names it only where it fits: a name past 14 letters does not, so the test failed on CI runners named like ip-10-0-138-101 and passed on the others. The test gives the board a name of its own. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
board_more::a_long_message_wraps…failed on some CI runners and passed on others for the same commit (5 of the last 40 runs, and one job each on #20 and #21).It asserted that the chat box's top edge names the machine at 44 columns, using the machine's real name. The edge shows the name only where it fits, and with "· Machine coordinator" after it a name past 14 letters does not. Runners named like
ip-10-0-138-101are 15.I reproduced it locally by giving the test that name: same assertion, same line. The test now gives the board a short name of its own, so it no longer depends on where it runs. A second assertion further down, for the folded box, looked for the machine's real name too and failed on CI once the first was fixed; it now asks for the same name. No program code changes.
npm run check board-more guardpasses, and all four CI jobs pass on this PR.🤖 Generated with Claude Code