Repository navigation
Fork: bring in review.prComment (no PR review comments) - #13
Merged
Merged
Conversation
Brought over from 809e63a4 (24 Oct, never merged) onto today's main. The default stays on, as upstream has it; turned off, the board posts no review comment on the task's pull request, and the review still runs, is judged at the gate and shows on the review page and in the task panel. The switch is read as each review ends, not when it starts, so turning it off during a review already counts. Every review that comments today (the first and later rounds, failed and passed, the chosen attempt's) goes through the one call in pipeline_end.rs. Tests run the same task with it on and off and check that the gh calls differ only by the review comments: nothing else the board writes to the pull request changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…fork-bring-in-review-prcomment
…fork-bring-in-review-prcomment
…fork-bring-in-review-prcomment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review comment on pull requests can now be turned off:
review.prCommentis on this branch (commitce91f714), ported from 809e63a4. The fullnpm run check -- --allpasses (1330 tests).Default: still on, as upstream has it. With it off, the board posts no review comment on the PR. The review still runs, is judged at the gate, and shows on the review page and in the task panel.
Conflicts: main had dropped
pr_number(...)from the onegh pr commentcall, so I kept main's version and added the switch. Two settings-page tests needed their screen height raised by one row for the new setting (65→66 and 66→67).One change from the old commit: the setting is now read when the review ends, not when it starts. A review can run 20 minutes, so turning it off during one already stops that comment.
Every path is covered: all reviews that post a comment today (first and later rounds, failed and passed, and the chosen attempt's review) go through that one call in
crates/flow/src/finish/pipeline_end.rs.Tests (
tests/gate_more.rs): the old test is kept. Two new tests run the same task with the switch on and off and compare everyghcall the board makes:The only difference between on and off is the review comments, so nothing else the board writes to the PR changes. I also removed the switch from the code as a test, and all three tests failed.
Docs:
docs/gate.mdanddocs/settings.md(the settings table was regenerated by the check).No version bump, tags, push or anything sent to eliasstravik/*.
Also noticed (not touched):
tests/coordinator.rs,tests/coordinator_chat.rs,tests/coordinator_chat_more.rs: the compiler warns about an unused variabletop.tests/board_list/pinned.rs:230: the compiler warns about a.clone()that does nothing.Task: PRJ-24 (herdr-projects/24)