prevent calling stats.toJson() - #1910
Open
pikpok wants to merge 1 commit into
Open
Conversation
Author
|
@fivethreeo could you take a look? 👀 or is Razzle abandoned and there's no way of getting this merged and released? 😅 |
|
looks good tbh.. need @fivethreeo approval |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use hasErrors/hasWarnings methods to check for errors on webpack stats, instead of always calling toJson(). Also, in case of errors use
errors-onlyorerrors-warningsstat config presets to avoid generating unnecessary stats.In our (quite large) Razzle project,
stats.toJson()call takes a lot of time and memory, and after migrating to webpack 5 even results in OOM errors on build.