Repository navigation
Conversation
np.eye(K)[y] allocated K squared floats to read one row; a zero vector with 1.0 at the label is the same float64 row, so every metric is bit-identical. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #267
Summary
metrics()and_row_scores()built each row's target asnp.eye(len(p))[y], allocating K² floats to read one row (finding 7 of a security scan of 2074cc4: a savedrows.jsonwith a very longpasks for a matrix of that size). A zero vector with 1.0 at the label is the same float64 row, so every metric is unchanged bit for bit.Verification
uv run --extra serve python -m pytest tests/test_unit.py tests/test_research.py tests/test_compare.py tests/test_rounds.py -q: 323 passed, 25 skipped.test_rounds.pyrecomputes the committed read-outs and compares every number exactly.kev.benchmark --run jaredpalmer/kev-0.8b@9a45d25 --suite evals/smoke-v1 --device cpufrom both trees.rows.jsonis byte-identical, and all 468 numeric fields ofreport.jsonmatch except wall-clock latency.Merge Danger
None: the numbers are bit-identical.
Generated with Devin