client/asyncio: break after subscription completion to avoid pop() on None#2
Closed
jacquelinegarrahan wants to merge 1 commit into
Closed
client/asyncio: break after subscription completion to avoid pop() on None#2jacquelinegarrahan wants to merge 1 commit into
jacquelinegarrahan wants to merge 1 commit into
Conversation
… None After a subscription completed, _handle set self._S = None but fell through into the enclosing `while self._run:` loop (unlike the cothread client, which breaks). The next iteration ran `S = self._S` (None) then `S.pop()` -> AttributeError, caught by the bare except and logged as "Error processing Subscription event" with a traceback on every normal monitor completion. Data was delivered correctly, but each finishing monitor emitted a spurious error. Break out of the loop after handling completion. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
Author
|
Superseded by the upstream PR epics-base#215 (opened against epics-base/p4p). Closing this fork PR to avoid duplicates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a subscription completed, _handle set self._S = None but fell through
into the enclosing
while self._run:loop (unlike the cothread client, whichbreaks). The next iteration ran
S = self._S(None) thenS.pop()->AttributeError, caught by the bare except and logged as
"Error processing Subscription event" with a traceback on every normal monitor
completion. Data was delivered correctly, but each finishing monitor emitted a
spurious error.
Break out of the loop after handling completion.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com