Repository navigation
Add shared plugin definition for network interfaces - #89
Conversation
Signed-off-by: Maximilian Moehl <maximilian@moehl.eu>
|
Looks good to me. With one glance one can see the contract. We can iterate on it, in case the inisix implementation needs more. |
Signed-off-by: Maximilian Moehl <maximilian@moehl.eu>
Signed-off-by: Maximilian Moehl <maximilian@moehl.eu>
|
I should mention that I deliberately left out the |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Why don't we go down a more CNI-like route? Like define an interface like in https://github.com/containernetworking/cni/blob/main/libcni/api.go#L103 + plugin config like https://github.com/containernetworking/cni/blob/main/pkg/types/types.go#L64 and then shell out like CNI does it? Also, how about calling it host network interface plugin (since it only makes sense in context of a single host)? |
Signed-off-by: Maximilian Moehl <maximilian@moehl.eu>
Signed-off-by: Maximilian Moehl <maximilian@moehl.eu>
We discussed this offline, we will go with this approach for now. |
No description provided.