Skip to content

Add shared plugin definition for network interfaces - #89

Merged
maxmoehl merged 5 commits into
ironcore-dev:mainfrom
sap-contributions:maxmoehl/nip
Oct 22, 2026
Merged

maxmoehl merged 5 commits into
ironcore-dev:mainfrom
sap-contributions:maxmoehl/nip

Conversation

@maxmoehl

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Maximilian Moehl <maximilian@moehl.eu>
@friegger

Copy link
Copy Markdown
Contributor

Looks good to me. With one glance one can see the contract. We can iterate on it, in case the inisix implementation needs more.

Comment thread plugin/networkinterface.go Resolved
Comment thread plugin/networkinterface.go Resolved
Comment thread plugin/networkinterface.go Resolved
Signed-off-by: Maximilian Moehl <maximilian@moehl.eu>
Signed-off-by: Maximilian Moehl <maximilian@moehl.eu>
@maxmoehl

Copy link
Copy Markdown
Member Author

I should mention that I deliberately left out the Init function. This is something that the plugin needs to sort out by itself as the parameters required for each plugin are probably different. The expectation is that each plugin exposes a New... function where it accepts the parameters it needs and performs any setup tasks.

@hardikdr hardikdr added the area/iaas Issues related to IronCore IaaS development. label Oct 20, 2026
@hardikdr hardikdr added this to Roadmap Oct 20, 2026
@maxmoehl
maxmoehl marked this pull request as ready for review October 20, 2026 08:57
@maxmoehl
maxmoehl requested review from a team as code owners October 20, 2026 08:57
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d04c8937-661a-4682-8027-bae6b446036d
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@adracus

adracus commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Why don't we go down a more CNI-like route? Like define an interface like in https://github.com/containernetworking/cni/blob/main/libcni/api.go#L103 + plugin config like https://github.com/containernetworking/cni/blob/main/pkg/types/types.go#L64 and then shell out like CNI does it? Also, how about calling it host network interface plugin (since it only makes sense in context of a single host)?

Signed-off-by: Maximilian Moehl <maximilian@moehl.eu>
Signed-off-by: Maximilian Moehl <maximilian@moehl.eu>

@lukasfrank lukasfrank left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo it looks good

@maxmoehl

Copy link
Copy Markdown
Member Author

Why don't we go down a more CNI-like route? Like define an interface like in https://github.com/containernetworking/cni/blob/main/libcni/api.go#L103 + plugin config like https://github.com/containernetworking/cni/blob/main/pkg/types/types.go#L64 and then shell out like CNI does it? Also, how about calling it host network interface plugin (since it only makes sense in context of a single host)?

We discussed this offline, we will go with this approach for now.

@maxmoehl
maxmoehl merged commit fb7f5eb into ironcore-dev:main Oct 22, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Oct 22, 2026
@maxmoehl
maxmoehl deleted the maxmoehl/nip branch October 22, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/iaas Issues related to IronCore IaaS development.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants