Repository navigation
Conversation
Adds the `l2rib` field to the NX-OS `System` CRD, exposing the four parameters of "l2rib dup-host-ip-addr-detection": move count, detection window, recovery timeout, and recovery count. The provider realizes this via a new `HMMFwdEvpn` struct written to System/hmm-items/fwdinst-items/evpn-items using PATCH semantics so that `FabricFwd`'s data at the parent path is not clobbered. The struct implements `Defaultable` so reset writes platform defaults (5/180/30/5) rather than deleting the subtree. Signed-off-by: Yurii Levchenko <yurii.levchenko@sap.com>
Signed-off-by: Yurii Levchenko <yurii.levchenko@sap.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
l2ribto the NX-OSSystemCRD to configurel2rib dup-host-ip-addr-detectionthresholds per device.Non-obvious decisions
The feature maps to
System/hmm-items/fwdinst-items/evpn-items(HMM, notSystem/l2rib-itemswhich is MAC/L2 dup detection). The provider usessb.Patch()on this path becausefwdinst-itemsis shared with the EVPN fabric provider — Replace would clobber sibling data. On deletion,Defaultableresets to platform defaults rather than deleting the path.Tests
testdata/l2rib.jsonsystem_l2rib.txtar— write, idempotency, resetsystem.txtarand bothsystem_dhcp_override*.txtarto include thehmm-itemsdefaults block (now unconditionally written byEnsureSystemSettings)