Skip to content

Add Configured condition to LLDP controller - #668

Merged
felix-kaestner merged 1 commit into
ironcore-dev:mainfrom
ObuMan:lldp-configured-condition
Oct 22, 2026
Merged

felix-kaestner merged 1 commit into
ironcore-dev:mainfrom
ObuMan:lldp-configured-condition

Conversation

@ObuMan

@ObuMan ObuMan commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Extract LLDP controller changes from feat/configured-condition (#426)

Adds a Configured condition to the LLDP controller. The controller was already wired to use conditions.FromError and conditions.RecomputeReady and sets Configured directly for all validation failures (missing InterfaceRef, duplicate LLDP per device, incompatible ProviderConfigRef). The only missing piece was InitializeConditions, which now includes ConfiguredCondition

Testing

Tested against a simulated Cisco N9K-C9300v (n9kv) in Containerlab

 % kubectl get lldp -o wide
 NAME         DEVICE   ADMIN STATE   READY   CONFIGURED   OPERATIONAL   PAUSED   AGE
 leaf1-lldp   leaf1    Up            True    True         True          False    7s

 % kubectl get lldp leaf1-lldp -o yaml
 # ...
 status:
   conditions:
   - lastTransitionTime: "2026-10-22T10:21:14Z"
     message: All conditions are ready
     observedGeneration: 1
     reason: Ready
     status: "True"
     type: Ready
   - lastTransitionTime: "2026-10-22T10:21:14Z"
     message: Configured successfully
     observedGeneration: 1
     reason: Configured
     status: "True"
     type: Configured
   - lastTransitionTime: "2026-10-22T10:21:14Z"
     message: LLDP is operationally up
     observedGeneration: 1
     reason: Operational
     status: "True"
     type: Operational
   - lastTransitionTime: "2026-10-22T10:21:11Z"
     message: ""
     observedGeneration: 1
     reason: NotPaused
     status: "False"
     type: Paused

Also verified the failure path: patched the LLDP to reference a non-existent Interface, which sets Configured=False with WaitingForDependencies and cascades to Ready=False

 % kubectl get lldp -o wide
 NAME         DEVICE   ADMIN STATE   READY   CONFIGURED   OPERATIONAL   PAUSED   AGE
 leaf1-lldp   leaf1    Down          False   False        False         False    24s

 % kubectl get lldp leaf1-lldp -o yaml
 # ...
 status:
   conditions:
   - lastTransitionTime: "2026-10-22T10:21:24Z"
     message: One or more conditions are not ready
     observedGeneration: 3
     reason: NotReady
     status: "False"
     type: Ready
   - lastTransitionTime: "2026-10-22T10:21:28Z"
     message: Interface non-existent-intf not found
     observedGeneration: 3
     reason: WaitingForDependencies
     status: "False"
     type: Configured

Signed-off-by: Vasyl Paliuha <vasyl.paliuha@sap.com>
@felix-kaestner
felix-kaestner enabled auto-merge (rebase) October 22, 2026 13:20
@felix-kaestner
felix-kaestner merged commit 2fcb61c into ironcore-dev:main Oct 22, 2026
20 of 22 checks passed
@ObuMan
ObuMan deleted the lldp-configured-condition branch October 25, 2026 17:34
@hardikdr hardikdr added the area/switch-automation Automation processes for network switch management and operations. label Nov 9, 2026
@hardikdr hardikdr added this to Roadmap Nov 9, 2026
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/switch-automation Automation processes for network switch management and operations.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants