Repository navigation
Add Configured condition to LLDP controller - #668
Merged
felix-kaestner merged 1 commit intoOct 22, 2026
Merged
Conversation
Signed-off-by: Vasyl Paliuha <vasyl.paliuha@sap.com>
felix-kaestner
approved these changes
Oct 22, 2026
felix-kaestner
enabled auto-merge (rebase)
October 22, 2026 13:20
felix-kaestner
disabled auto-merge
October 22, 2026 13:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract LLDP controller changes from feat/configured-condition (#426)
Adds a
Configuredcondition to the LLDP controller. The controller was already wired to useconditions.FromErrorandconditions.RecomputeReadyand setsConfigureddirectly for all validation failures (missing InterfaceRef, duplicate LLDP per device, incompatible ProviderConfigRef). The only missing piece wasInitializeConditions, which now includesConfiguredConditionTesting
Tested against a simulated Cisco N9K-C9300v (n9kv) in Containerlab
Also verified the failure path: patched the LLDP to reference a non-existent Interface, which sets
Configured=FalsewithWaitingForDependenciesand cascades toReady=False