Repository navigation
Add Configured condition to AccessControlList controller - #657
Merged
felix-kaestner merged 1 commit intoOct 21, 2026
Merged
Conversation
Signed-off-by: Vasyl Paliuha <vasyl.paliuha@sap.com>
ObuMan
force-pushed
the
acl-configured-condition
branch
from
October 21, 2026 10:59
392aee7 to
0f6ad1c
Compare
felix-kaestner
approved these changes
Oct 21, 2026
felix-kaestner
enabled auto-merge (rebase)
October 21, 2026 13:01
felix-kaestner
disabled auto-merge
October 21, 2026 13:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract AccessControlList controller changes from feat/configured-condition (#426)
Testing
Tested against a simulated Cisco N9K-C9300v (n9kv) in Containerlab using the provided ACL sample.
Also verified the failure path: applying an ACL entry with mismatched IP versions (IPv4 source, IPv6 destination) causes the provider to reject the configuration, setting
Configured=Falsewith the error as the message, andReadyis recomputed toFalse.