Skip to content

Add Configured condition to AccessControlList controller - #657

Merged
felix-kaestner merged 1 commit into
ironcore-dev:mainfrom
ObuMan:acl-configured-condition
Oct 21, 2026
Merged

felix-kaestner merged 1 commit into
ironcore-dev:mainfrom
ObuMan:acl-configured-condition

Conversation

@ObuMan

@ObuMan ObuMan commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Extract AccessControlList controller changes from feat/configured-condition (#426)

Testing

Tested against a simulated Cisco N9K-C9300v (n9kv) in Containerlab using the provided ACL sample.

 % kubectl get accesscontrollist -o wide
 NAME   ACL    DEVICE   ENTRIES   READY   CONFIGURED   PAUSED   AGE
 acl    MGMT   leaf1    1 entry   True    True         False    65s

 % kubectl get accesscontrollist acl -o yaml
 apiVersion: networking.metal.ironcore.dev/v1alpha1
 kind: AccessControlList
 # ...
 status:
   conditions:
   - lastTransitionTime: "2026-10-21T08:57:48Z"
     message: All conditions are ready
     observedGeneration: 1
     reason: Ready
     status: "True"
     type: Ready
   - lastTransitionTime: "2026-10-21T08:57:48Z"
     message: Configured successfully
     observedGeneration: 1
     reason: Configured
     status: "True"
     type: Configured
   - lastTransitionTime: "2026-10-21T08:57:17Z"
     message: ""
     observedGeneration: 1
     reason: NotPaused
     status: "False"
     type: Paused

Also verified the failure path: applying an ACL entry with mismatched IP versions (IPv4 source, IPv6 destination) causes the provider to reject the configuration, setting Configured=False with the error as the message, and Ready is recomputed to False.

 % kubectl get accesscontrollist acl -o yaml
 # ...
 status:
   conditions:
   - lastTransitionTime: "2026-10-21T09:00:32Z"
     message: One or more conditions are not ready
     observedGeneration: 2
     reason: NotReady
     status: "False"
     type: Ready
   - lastTransitionTime: "2026-10-21T09:00:32Z"
     message: 'acl: rule contains mismatched ip versions in source and destination
       addresses'
     observedGeneration: 2
     reason: Error
     status: "False"
     type: Configured
   - lastTransitionTime: "2026-10-21T08:59:53Z"
     message: ""
     observedGeneration: 2
     reason: NotPaused
     status: "False"
     type: Paused

Signed-off-by: Vasyl Paliuha <vasyl.paliuha@sap.com>
@ObuMan
ObuMan force-pushed the acl-configured-condition branch from 392aee7 to 0f6ad1c Compare October 21, 2026 10:59
@felix-kaestner
felix-kaestner enabled auto-merge (rebase) October 21, 2026 13:01
@felix-kaestner
felix-kaestner merged commit 00bc3f9 into ironcore-dev:main Oct 21, 2026
19 of 21 checks passed
@hardikdr hardikdr added the area/switch-automation Automation processes for network switch management and operations. label Nov 9, 2026
@hardikdr hardikdr added this to Roadmap Nov 9, 2026
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/switch-automation Automation processes for network switch management and operations.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants