Repository navigation
Add Configured condition to DNS controller - #633
Merged
felix-kaestner merged 2 commits intoOct 14, 2026
Merged
Conversation
Contributor
|
Nice! Please wait for the discussion with @felix-kaestner in #627 regarding error handling of |
adamtrizuljak-sap
approved these changes
Oct 14, 2026
adamtrizuljak-sap
left a comment
Contributor
There was a problem hiding this comment.
Looks good. This controller doesn't have additional error cases that need to be considered (see discussion in #627).
felix-kaestner
approved these changes
Oct 14, 2026
Signed-off-by: Vasyl Paliuha <vasyl.paliuha@sap.com>
Signed-off-by: Vasyl Paliuha <vasyl.paliuha@sap.com>
ObuMan
force-pushed
the
dns-configured-condition
branch
from
October 14, 2026 12:09
d8c0481 to
18558ae
Compare
lparz1val
pushed a commit
to lparz1val/network-operator
that referenced
this pull request
Oct 15, 2026
Signed-off-by: Vasyl Paliuha <vasyl.paliuha@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract DNS controller + test changes from branch feat/configured-condition #426
Find error paths in the controller and handle them by setting the Configured condition via conditions.FromError(err).
Testing
Tested against a simulated Cisco N9K-C9300v (n9kv) in Containerlab using the provided DNS sample.
Also verified the failure path: when the device is reachable but applying the configuration fails, the controller sets
Configured=Falsewith the provider error as the message, andReadyis recomputed toFalse. For example, pointing a name server at a non-existent VRF makes the device reject the Set: