Skip to content

Support NX-OS ND suppress-ra and ra-interval - #581

Merged
felix-kaestner merged 1 commit into
ironcore-dev:mainfrom
oliver-frommel:support-nxos-nd-suppress-ra-ip-forward
Oct 15, 2026
Merged

felix-kaestner merged 1 commit into
ironcore-dev:mainfrom
oliver-frommel:support-nxos-nd-suppress-ra-ip-forward

Conversation

@oliver-frommel

@oliver-frommel oliver-frommel commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Add spec.ipv6 to the NX-OS InterfaceConfig with suppressRouterAdvertisement and routerAdvertisementInterval (4s to 30m). Neighbor Discovery is only managed while spec.ipv6 is set, and only the suppress-ra flag is touched, so settings configured by other means stay as they are.

"ip forward" is not included, as IPv6-only peering doesn't need it.

@oliver-frommel
oliver-frommel marked this pull request as draft September 18, 2026 09:50
@hardikdr hardikdr added the area/switch-automation Automation processes for network switch management and operations. label Sep 19, 2026
@hardikdr hardikdr added this to Roadmap Sep 19, 2026
@oliver-frommel
oliver-frommel force-pushed the support-nxos-nd-suppress-ra-ip-forward branch from 7bb0b5d to 9d2be05 Compare September 24, 2026 15:19
@oliver-frommel
oliver-frommel force-pushed the support-nxos-nd-suppress-ra-ip-forward branch from 9d2be05 to 1f464e2 Compare October 2, 2026 08:58
@oliver-frommel
oliver-frommel marked this pull request as ready for review October 2, 2026 11:40
@oliver-frommel oliver-frommel changed the title Support nxos nd suppress-ra and ra-interval Support NX-OS ND suppress-ra and ra-interval Oct 2, 2026
@swagner-de swagner-de added the review-scheduled The PR is being reviewed. label Oct 8, 2026
Comment thread config/samples/v1alpha1_interface.yaml Resolved
Comment thread internal/provider/cisco/nxos/intf.go Resolved
@oliver-frommel
oliver-frommel force-pushed the support-nxos-nd-suppress-ra-ip-forward branch from 1f464e2 to a9612f8 Compare October 13, 2026 10:51
@oliver-frommel

Copy link
Copy Markdown
Contributor Author

Hi @felix-kaestner I've updated the PR with the requestes changes. Please have a look, thanks.

@felix-kaestner

felix-kaestner commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

@oliver-frommel could you look into the failing CI?

For the spell checks, I think you can just add a ingore in https://github.com/ironcore-dev/network-operator/blob/main/.typos.toml.

Failures on the Size Label and Coverage Comment are expected because of permissions (still need to follow up and fix this at some point, don't worry about it for now).

@oliver-frommel
oliver-frommel force-pushed the support-nxos-nd-suppress-ra-ip-forward branch from a9612f8 to 17c584e Compare October 13, 2026 14:57
@oliver-frommel

Copy link
Copy Markdown
Contributor Author

I've added the exception to the TOML file.

@felix-kaestner

Copy link
Copy Markdown
Collaborator

Hey @oliver-frommel, the gNMI Integration Tests are failing in https://github.com/ironcore-dev/network-operator/actions/runs/38417939869/job/115369441065?pr=581. Could you look into that? 🙏

Signed-off-by: Oliver Frommel <oliver.frommel@bwi.de>
@oliver-frommel
oliver-frommel force-pushed the support-nxos-nd-suppress-ra-ip-forward branch from 17c584e to 5adf770 Compare October 14, 2026 19:43
@felix-kaestner
felix-kaestner enabled auto-merge (rebase) October 15, 2026 09:13
@felix-kaestner
felix-kaestner merged commit 3c77048 into ironcore-dev:main Oct 15, 2026
20 of 22 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/switch-automation Automation processes for network switch management and operations. review-scheduled The PR is being reviewed.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants