Skip to content

feat: Implement BFD for BGPPeers - #438

Merged
sven-rosenzweig merged 1 commit into
mainfrom
feat/bfd_for_bgppeer
Oct 16, 2026
Merged

sven-rosenzweig merged 1 commit into
mainfrom
feat/bfd_for_bgppeer

Conversation

@sven-rosenzweig

Copy link
Copy Markdown
Contributor

No description provided.

@sven-rosenzweig
sven-rosenzweig force-pushed the feat/bfd_for_bgppeer branch 2 times, most recently from 3400add to 37e3c78 Compare July 10, 2026 10:38
Comment thread api/core/v1alpha1/bfd_types.go Resolved
Comment thread api/core/v1alpha1/bgp_peer_types.go Resolved
Comment thread internal/provider/cisco/nxos/bgp.go Resolved
Comment thread internal/provider/cisco/nxos/bgp.go Resolved
Comment thread internal/provider/cisco/nxos/bgp.go Resolved
Comment thread internal/provider/cisco/nxos/bgp.go Resolved
Comment thread internal/provider/cisco/nxos/bgp.go Resolved
@sven-rosenzweig
sven-rosenzweig marked this pull request as ready for review July 22, 2026 12:08
Comment thread internal/provider/cisco/nxos/bgp.go Resolved
Comment thread internal/provider/cisco/nxos/bgp.go Resolved
@sven-rosenzweig
sven-rosenzweig force-pushed the feat/bfd_for_bgppeer branch 5 times, most recently from 561ffb8 to 57ef8b7 Compare August 14, 2026 08:23
@hardikdr hardikdr added the area/switch-automation Automation processes for network switch management and operations. label Aug 21, 2026
@hardikdr hardikdr added this to Roadmap Aug 21, 2026
@swagner-de swagner-de added review-scheduled The PR is being reviewed. and removed review-scheduled The PR is being reviewed. labels Sep 24, 2026
@swagner-de swagner-de added the review-scheduled The PR is being reviewed. label Oct 8, 2026
Comment thread internal/provider/cisco/nxos/bgp.go Resolved
Comment thread internal/provider/cisco/nxos/bgp.go Resolved
@sven-rosenzweig
sven-rosenzweig force-pushed the feat/bfd_for_bgppeer branch 3 times, most recently from b4b9d0f to a1de11d Compare October 15, 2026 09:51
Signed-off-by: Sven Rosenzweig <sven.rosenzweig@sap.com>
@github-actions

Copy link
Copy Markdown

Merging this branch changes the coverage (4 decrease, 2 increase)

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1 2.43% (-0.00%) 👎
github.com/ironcore-dev/network-operator/internal/controller/core 60.27% (+0.06%) 👍
github.com/ironcore-dev/network-operator/internal/controller/evpn 81.20% (+0.15%) 👍
github.com/ironcore-dev/network-operator/internal/controller/overlay 68.18% (-2.73%) 👎
github.com/ironcore-dev/network-operator/internal/controller/pool 73.00% (-2.11%) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/iosxr 41.18% (-1.16%) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos 16.45% (-0.14%) 👎
Coverage details

Compared to commit 3c77048 (run #38711488915)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1/bfd_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/bgp_peer_types.go 11.11% (ø) 9 1 8
github.com/ironcore-dev/network-operator/api/core/v1alpha1/interface_types.go 3.57% (ø) 28 1 27
github.com/ironcore-dev/network-operator/api/core/v1alpha1/zz_generated.deepcopy.go 0.00% (ø) 2876 (+4) 0 2876 (+4)
github.com/ironcore-dev/network-operator/internal/provider/cisco/iosxr/bgp_peer.go 54.29% (ø) 35 19 16
github.com/ironcore-dev/network-operator/internal/provider/cisco/iosxr/provider.go 19.52% (-1.07%) 251 (+13) 49 202 (+13) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/bgp.go 20.48% (-5.28%) 83 (+17) 17 66 (+17) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go 4.35% (-0.02%) 2504 (+14) 109 2395 (+14) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files:

  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/bgp_test.go

@sven-rosenzweig
sven-rosenzweig merged commit 4129c20 into main Oct 16, 2026
26 checks passed
@sven-rosenzweig
sven-rosenzweig deleted the feat/bfd_for_bgppeer branch October 16, 2026 14:48
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/switch-automation Automation processes for network switch management and operations. review-scheduled The PR is being reviewed. size/L

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants