Skip to content

Standardize administrative state using AdminState enum across resources - #144

Merged
felix-kaestner merged 1 commit into
mainfrom
admin-state
Jan 9, 2026
Merged

felix-kaestner merged 1 commit into
mainfrom
admin-state

Conversation

@felix-kaestner

Copy link
Copy Markdown
Collaborator

This patch harmonizes the API for setting a administrative state on resources using the AdminState enumeration and introduces this field for protocols (BGP, OSPF, ISIS, PIM) and system level services (NTP, DNS).

This patch harmonizes the API for setting a administrative state on
resources using the AdminState enumeration and introduces this field for
protocols (BGP, OSPF, ISIS, PIM) and system level services (NTP, DNS).
@felix-kaestner
felix-kaestner force-pushed the admin-state branch 2 times, most recently from fcf5e9d to 68297f5 Compare January 9, 2026 11:53
@github-actions

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1 0.00% (ø)
github.com/ironcore-dev/network-operator/api/core/v1alpha1 0.00% (ø)
github.com/ironcore-dev/network-operator/internal/controller/core 69.33% (-0.27%) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos 11.20% (-0.18%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/bordergateway_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/vpcdomain_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/bgp_peer_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/bgp_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/dns_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/interface_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/isis_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/ntp_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/ospf_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/pim_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/ref_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/vlan_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/bgp.go 21.15% (ø) 52 11 41
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/ntp.go 50.00% (-16.67%) 4 (+1) 2 2 (+1) 💀
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/pim.go 50.00% (-10.00%) 12 (+2) 6 6 (+2) 👎
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go 0.07% (-0.00%) 1406 (+30) 1 1405 (+30) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/ironcore-dev/network-operator/internal/controller/core/evpninstance_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/interface_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/vlan_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/bgp_test.go

@felix-kaestner
felix-kaestner merged commit 79d7e23 into main Jan 9, 2026
8 checks passed
@felix-kaestner
felix-kaestner deleted the admin-state branch January 9, 2026 11:59
@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Jan 13, 2026
@hardikdr hardikdr added this to Roadmap Jan 13, 2026
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Jan 13, 2026
felix-kaestner added a commit that referenced this pull request Jan 26, 2026
…es (#144)

This patch harmonizes the API for setting a administrative state on
resources using the AdminState enumeration and introduces this field for
protocols (BGP, OSPF, ISIS, PIM) and system level services (NTP, DNS).
@hardikdr hardikdr added the area/switch-automation Automation processes for network switch management and operations. label Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/metal-automation Automation processes within the Metal project. area/switch-automation Automation processes for network switch management and operations.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants