Skip to content

Add validation webhook to validate bgp AS number - #142

Merged
felix-kaestner merged 1 commit into
mainfrom
bgp-validation
Jan 9, 2026
Merged

felix-kaestner merged 1 commit into
mainfrom
bgp-validation

Conversation

@felix-kaestner

Copy link
Copy Markdown
Collaborator

No description provided.

@felix-kaestner
felix-kaestner requested a review from a team December 15, 2025 12:05
@felix-kaestner felix-kaestner changed the title Add validation webhook to validate bgp as number Add validation webhook to validate bgp AS number Dec 15, 2025
@felix-kaestner
felix-kaestner force-pushed the bgp-validation branch 2 times, most recently from a1d67f4 to a610992 Compare December 15, 2025 12:20
@felix-kaestner
felix-kaestner force-pushed the bgp-validation branch 2 times, most recently from 565b954 to 5ff9caf Compare December 17, 2025 15:01
@felix-kaestner
felix-kaestner force-pushed the bfd branch 2 times, most recently from 8e49603 to 346e597 Compare January 5, 2026 07:48
Base automatically changed from bfd to main January 9, 2026 11:24
@github-actions

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/cmd 0.00% (ø)
github.com/ironcore-dev/network-operator/internal/webhook/core/v1alpha1 87.97% (-1.74%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/cmd/main.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/internal/webhook/core/v1alpha1/bgp_webhook.go 87.18% (+87.18%) 39 (+39) 34 (+34) 5 (+5) 🌟
github.com/ironcore-dev/network-operator/internal/webhook/core/v1alpha1/bgppeer_webhook.go 75.00% (+75.00%) 12 (+12) 9 (+9) 3 (+3) 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/ironcore-dev/network-operator/internal/webhook/core/v1alpha1/bgp_webhook_test.go
  • github.com/ironcore-dev/network-operator/internal/webhook/core/v1alpha1/bgppeer_webhook_test.go
  • github.com/ironcore-dev/network-operator/internal/webhook/core/v1alpha1/prefixset_webhook_test.go

@felix-kaestner
felix-kaestner merged commit d334bfc into main Jan 9, 2026
8 checks passed
@felix-kaestner
felix-kaestner deleted the bgp-validation branch January 9, 2026 11:32
@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Jan 13, 2026
@hardikdr hardikdr added this to Roadmap Jan 13, 2026
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Jan 13, 2026
@hardikdr hardikdr added the area/switch-automation Automation processes for network switch management and operations. label Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/metal-automation Automation processes within the Metal project. area/switch-automation Automation processes for network switch management and operations.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants