Skip to content

Add bfd settings to Interface resource - #139

Merged
felix-kaestner merged 5 commits into
mainfrom
bfd
Jan 9, 2026
Merged

felix-kaestner merged 5 commits into
mainfrom
bfd

Conversation

@felix-kaestner

Copy link
Copy Markdown
Collaborator

No description provided.

@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Dec 9, 2025
@hardikdr hardikdr added this to Roadmap Dec 9, 2025
@felix-kaestner
felix-kaestner force-pushed the nx/bgw branch 2 times, most recently from 184f939 to b35c016 Compare December 11, 2025 15:54
@felix-kaestner
felix-kaestner force-pushed the bfd branch 3 times, most recently from 9f028d8 to c9fa40e Compare December 12, 2025 15:17
@felix-kaestner
felix-kaestner marked this pull request as ready for review December 12, 2025 15:18
@felix-kaestner
felix-kaestner requested a review from a team December 12, 2025 15:18
Comment thread api/core/v1alpha1/interface_types.go Resolved
@felix-kaestner
felix-kaestner force-pushed the nx/bgw branch 3 times, most recently from 2a25ff1 to 1b76846 Compare January 9, 2026 11:09
Base automatically changed from nx/bgw to main January 9, 2026 11:16
Assisted-by: Claude Code
Instead the enablement of bfd for the link is implicitly inferred from
the `.spec.bfd.enabled` on the referenced `Interface`.
This patch adds support for automatically disabling icmp redirects on
IPv4 links that are running BFD sessions, equivalent to the
configuration of:

```
interface Ethernet1/1
 no ip redirects
```
This patch automatically infers the configuration for bfd on an ospf
link according to the following config based on the `.spec.bfd.enabled`
field in the `Interface` resource.

```
interface Ethernet1/1
 ip ospf bfd
```
@github-actions

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1 0.00% (ø)
github.com/ironcore-dev/network-operator/internal/controller/core 69.60% (+0.12%) 👍
github.com/ironcore-dev/network-operator/internal/provider 20.00% (ø)
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos 11.39% (-0.24%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/api/core/v1alpha1/interface_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/isis_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/zz_generated.deepcopy.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/internal/controller/core/isis_controller.go 64.08% (ø) 103 66 37
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/intf.go 19.40% (+0.20%) 134 (+9) 26 (+2) 108 (+7) 👍
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/ospf.go 25.00% (ø) 16 4 12
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go 0.07% (-0.00%) 1376 (+50) 1 1375 (+50) 👎
github.com/ironcore-dev/network-operator/internal/provider/provider.go 20.00% (ø) 25 5 20

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/intf_test.go
  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/ospf_test.go

@felix-kaestner
felix-kaestner merged commit 4aede42 into main Jan 9, 2026
8 checks passed
@felix-kaestner
felix-kaestner deleted the bfd branch January 9, 2026 11:24
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Jan 9, 2026
@hardikdr hardikdr added the area/switch-automation Automation processes for network switch management and operations. label Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/metal-automation Automation processes within the Metal project. area/switch-automation Automation processes for network switch management and operations.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants