Repository navigation
Add bfd settings to Interface resource - #139
Merged
Merged
Conversation
felix-kaestner
force-pushed
the
nx/bgw
branch
from
December 10, 2025 15:02
86d05e5 to
2b5f774
Compare
felix-kaestner
force-pushed
the
nx/bgw
branch
2 times, most recently
from
December 11, 2025 15:54
184f939 to
b35c016
Compare
felix-kaestner
force-pushed
the
nx/bgw
branch
from
December 12, 2025 11:39
b35c016 to
e484e01
Compare
felix-kaestner
force-pushed
the
bfd
branch
3 times, most recently
from
December 12, 2025 15:17
9f028d8 to
c9fa40e
Compare
felix-kaestner
marked this pull request as ready for review
December 12, 2025 15:18
felix-kaestner
force-pushed
the
nx/bgw
branch
from
December 15, 2025 12:03
e484e01 to
c4225a1
Compare
felix-kaestner
force-pushed
the
nx/bgw
branch
from
December 16, 2025 09:04
c4225a1 to
053ec42
Compare
felix-kaestner
force-pushed
the
nx/bgw
branch
from
December 19, 2025 15:03
053ec42 to
09abac5
Compare
nikatza
approved these changes
Dec 30, 2025
felix-kaestner
force-pushed
the
nx/bgw
branch
3 times, most recently
from
January 9, 2026 10:13
f40d8d2 to
7767063
Compare
felix-kaestner
force-pushed
the
nx/bgw
branch
3 times, most recently
from
January 9, 2026 11:09
2a25ff1 to
1b76846
Compare
Assisted-by: Claude Code
Instead the enablement of bfd for the link is implicitly inferred from the `.spec.bfd.enabled` on the referenced `Interface`.
This patch adds support for automatically disabling icmp redirects on IPv4 links that are running BFD sessions, equivalent to the configuration of: ``` interface Ethernet1/1 no ip redirects ```
This patch automatically infers the configuration for bfd on an ospf link according to the following config based on the `.spec.bfd.enabled` field in the `Interface` resource. ``` interface Ethernet1/1 ip ospf bfd ```
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.