Skip to content

Migrate Helm chart from helm/v1-alpha to helm/v2-alpha plugin - #409

Merged
afritzler merged 1 commit into
ironcore-dev:mainfrom
afritzler:chore/kubebuilder
Nov 18, 2026
Merged

afritzler merged 1 commit into
ironcore-dev:mainfrom
afritzler:chore/kubebuilder

Conversation

@afritzler

@afritzler afritzler commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Proposed Changes

Migrate Helm chart from helm/v1-alpha to helm/v2-alpha plugin.

Fixes #274

⚠️ Breaking change: Helm chart values *.enable renamed to *.enabled

The Helm chart was regenerated with kubebuilder v4.16.0, which includes kubernetes-sigs/kubebuilder#5736. It standardizes all feature toggle values from singular enable to plural enabled, e.g.:

# Before
prometheus:
  enable: true

# After
prometheus:
  enabled: true

Affected toggles: serviceAccount, prometheus, crd, certManager, webhook, metrics, networkPolicy, rbac.helpers.

Action required: if you deploy the chart with a custom values.yaml or --set flags using the old *.enable keys, update them to *.enabled when upgrading to this release. Old keys are silently ignored (toggles fall back to their defaults), so e.g. --set prometheus.enable=true no longer installs the ServiceMonitor.

Signed-off-by: Andreas Fritzler <andreas.fritzler@sap.com>
@afritzler
afritzler requested a review from a team as a code owner November 18, 2026 09:19
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e29e745e-1a68-451b-aab2-d567e2f1eb3f
Commits

Reviewing files that changed from the base of the PR and between 687cc26 and e525db7.

Files ignored due to path filters: 38

  • dist/chart/Chart.yaml is excluded by !**/dist/**
  • dist/chart/templates/NOTES.txt is excluded by !**/dist/**
  • dist/chart/templates/_helpers.tpl is excluded by !**/dist/**
  • dist/chart/templates/cert-manager/metrics-certs.yaml is excluded by !**/dist/**
  • dist/chart/templates/cert-manager/selfsigned-issuer.yaml is excluded by !**/dist/**
  • dist/chart/templates/certmanager/certificate.yaml is excluded by !**/dist/**
  • dist/chart/templates/crd/httpbootconfigs.boot.ironcore.dev.yaml is excluded by !**/dist/**
  • dist/chart/templates/crd/ipxebootconfigs.boot.ironcore.dev.yaml is excluded by !**/dist/**
  • dist/chart/templates/manager/manager.yaml is excluded by !**/dist/**
  • dist/chart/templates/manager/service.yaml is excluded by !**/dist/**
  • dist/chart/templates/metrics/controller-manager-metrics-service.yaml is excluded by !**/dist/**
  • dist/chart/templates/metrics/metrics-service.yaml is excluded by !**/dist/**
  • dist/chart/templates/network-policy/allow-metrics-traffic.yaml is excluded by !**/dist/**
  • dist/chart/templates/prometheus/controller-manager-metrics-monitor.yaml is excluded by !**/dist/**
  • dist/chart/templates/prometheus/monitor.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/auth_proxy_client_clusterrole.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/auth_proxy_role.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/auth_proxy_role_binding.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/auth_proxy_service.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/controller-manager.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/httpbootconfig_editor_role.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/httpbootconfig_viewer_role.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/ipxebootconfig_editor_role.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/ipxebootconfig_viewer_role.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/leader-election-role.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/leader-election-rolebinding.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/leader_election_role_binding.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/manager-role.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/manager-rolebinding.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/metrics-auth-role.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/metrics-auth-rolebinding.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/metrics-reader.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/metrics_auth_role_binding.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/metrics_reader_role.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/role_binding.yaml is excluded by !**/dist/**
  • dist/chart/templates/rbac/service_account.yaml is excluded by !**/dist/**
  • dist/chart/values.yaml is excluded by !**/dist/**
  • dist/install.yaml is excluded by !**/dist/**
Files selected for processing: 6

  • .github/workflows/publish-chart.yml
  • .github/workflows/test-chart.yml
  • Makefile
  • PROJECT
  • config/manager/kustomization.yaml
  • docs/usage/installation.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@hardikdr hardikdr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, as it touches charts, may be @defo89 @atd9876 might be interested as well.

@afritzler
afritzler merged commit 1578072 into ironcore-dev:main Nov 18, 2026
30 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Migrate from helm/v1-alpha (deprecated) to helm/v2-alpha

2 participants