Skip to content

Add tests to IPAM plugin - #257

Merged
damyan merged 1 commit into
mainfrom
enh/test-ipam
Oct 6, 2026
Merged

damyan merged 1 commit into
mainfrom
enh/test-ipam

Conversation

@KapilYadava

@KapilYadava KapilYadava commented Feb 10, 2025 •

Copy link
Copy Markdown
Contributor

Fixes #92 for IPAM

@github-actions github-actions Bot added enhancement New feature or request size/L labels Feb 10, 2025
@KapilYadava KapilYadava changed the title Add test for IPAM plugin Add test to IPAM plugin Feb 13, 2025
@KapilYadava
KapilYadava requested a review from damyan February 13, 2025 07:30
@KapilYadava
KapilYadava marked this pull request as ready for review February 13, 2025 07:31
@KapilYadava KapilYadava self-assigned this Feb 13, 2025
@damyan damyan changed the title Add test to IPAM plugin Add tests to IPAM plugin Feb 17, 2025

@damyan damyan left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improvements needed:

  • squash first 4 commits to a single one, adding some meaningful name (adding some meaningful names for commits/branches/PRs/descriptions is generally a good idea, because those will appear on default branch history)
  • enhance the create IPAM IP tests to:
    • create a new IPAM IP for some MAC address
    • update already created IPAM IP for the same MAC, because IP address differs
    • update already created IPAM IP for the same MAC, because subnet differs
  • remove redundant creation of default config. idea:
    • change loadConfig() to setup6() in suite_test, so the client is parametrized with the proper configuration. use that config in all straightforward tests
    • delete config creation from plugin_test
    • whenever a different/wrong/malformed/non-existent config is needed: create it in the test and call loadConfig()

Let's discuss the changes in our next meeting

@hardikdr hardikdr added this to Roadmap May 4, 2025
@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Jun 25, 2025
@mTarabyte
mTarabyte requested a review from damyan October 5, 2026 13:14
Signed-off-by: Damyan Yordanov <damyan.yordanov@sap.com>
@damyan
damyan requested a review from a team as a code owner October 6, 2026 12:28
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: afc79e0e-a929-4bc5-8814-bb5d0287a3a8
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@damyan
damyan merged commit 230ed0f into main Oct 6, 2026
10 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Oct 6, 2026
@damyan
damyan deleted the enh/test-ipam branch October 6, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/metal-automation Automation processes within the Metal project. enhancement New feature or request size/L

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add tests for all plugins

3 participants