Skip to content

Update workflow name - #12

Merged
irfanghat merged 3 commits into
mainfrom
dev
Dec 28, 2025
Merged

irfanghat merged 3 commits into
mainfrom
dev

Conversation

@irfanghat

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings December 27, 2025 22:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the workflow name in the GitHub Actions configuration file from "C++ CI" to "Run Tests" to better reflect the workflow's purpose.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@irfanghat
irfanghat merged commit 3280982 into main Dec 28, 2025
2 of 3 checks passed
Comment on lines +11 to +46
runs-on: ubuntu-latest

services:
spark:
image: apache/spark:4.0.0-scala2.13-java21-r-ubuntu
ports:
- 15002:15002
options: >-
--name spark_server
--health-cmd "nc -z localhost 15002"
--health-interval 10s
--health-timeout 5s
--health-retries 5
env:
SPARK_NO_DAEMONIZE: "true"

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Install dependencies
if: runner.os == 'Linux'
run: chmod +x install_deps.sh && ./install_deps.sh
run: |
chmod +x install_deps.sh
sudo ./install_deps.sh

- name: Check dependencies
run: make check-deps

- name: Build Spark Connect Client
- name: Build Spark Connect Client Library
run: make all

- name: Run tests
run: make run && make test_columns && make run_tests
- name: Build Tests
run: make build-tests

- name: Run Tests
run: make test No newline at end of file

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium test

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI 11 months ago

In general, the problem is resolved by explicitly specifying a minimal permissions block for the workflow or for the specific job, so that GITHUB_TOKEN does not inherit potentially broad repository defaults. For this workflow, the steps only require reading the repository contents for checkout; they do not need to write to the repo or interact with issues/PRs. Therefore, we can safely set permissions: contents: read.

The single best fix, without changing existing functionality, is to add a permissions block at the workflow root (top level, alongside name and on). This will apply to all jobs in this workflow and satisfy CodeQL’s requirement. Concretely, in .github/workflows/test.yml, insert:

permissions:
  contents: read

between the name: "Build and Test" line and the on: block. No other code, steps, or jobs need to be modified, and no imports or external libraries are required, because this is purely a YAML configuration change in the workflow file.

Suggested changeset 1
.github/workflows/test.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -1,5 +1,8 @@
 name: "Build and Test"
 
+permissions:
+  contents: read
+
 on:
   push:
     branches: [ "main" ]
EOF
@@ -1,5 +1,8 @@
name: "Build and Test"

permissions:
contents: read

on:
push:
branches: [ "main" ]
Copilot is powered by AI and may make mistakes. Always verify output.
irfanghat added a commit that referenced this pull request Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants