mockhsm: adds support for object attestation

[baloo]

No description provided.

[wiktor-k]

Hmm... wanted to try it out locally but there are so many issues with dependency drift (e.g. no rustcrypto-new-releases in https://github.com/dalek-cryptography/curve25519-dalek, can be easily reproduced by removing Cargo.lock and running cargo check) 😬 and then the drift between what is used here and what's in rpgp.

It'd be nice to get a new release of Yubihsm.rs with stable deps (e.g. it wants ed25519-dalek = "=2.2.0-pre" here but there's no such -pre version, but there's a stable one...) 😵

Oh well, that's just me complaining 😅

[baloo]

The rand_core 0.9 branch just merged and we got a pre-release for it over in curve25519-dalek. I need to make a pass at bumping the dependencies.

I can try to do that later today.

[wiktor-k]

I can try to do that later today.

There's no time pressure. I really appreciate your work 🙏 . MockHSM feature of this crate is really, really sweet. Essential for integration tests 🤩

[baloo]

And invaluable for onboarding people on a project without shipping them actual hardware ^^

[baloo]

@wiktor-k this should be better

[wiktor-k]

Thanks! I got further (I had to patch the ccm, just like you). But then during cargo check the conflict with ecdsa has arisen 😬 (I assume it's due to rpgp using a different version but it's kind-of sad the compiler can't properly wire the versions together :/ ):

    Checking ecdsa v0.17.0-rc.4
error[E0432]: unresolved import `signature::PrehashSignature`
  --> /home/wiktor/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ecdsa-0.17.0-rc.4/src/hazmat.rs:34:9
   |
34 |         PrehashSignature,
   |         ^^^^^^^^^^^^^^^^ no `PrehashSignature` in the root

error[E0405]: cannot find trait `PrehashSignature` in crate `signature`
   --> /home/wiktor/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ecdsa-0.17.0-rc.4/src/der.rs:397:20
    |
397 | impl<C> signature::PrehashSignature for Signature<C>
    |                    ^^^^^^^^^^^^^^^^ not found in `signature`

The change is fairly simple and if you want to check it it's in a separate branch clonable via git clone https://gitlab.archlinux.org/wiktor/yubihsm-pgp -b wiktor/attestation.

If not... well... I'll wait until these versions stabilize a bit :)

[tony-iqlusion]

@wiktor-k we've recently landed several upgrades including a prerelease of ed25519-dalek which would actually make a crate prerelease of yubihsm possible. Pardon our dust.

In the meantime please upgrade to ecdsa v0.17.0-rc.5

[wiktor-k]

we've recently landed several upgrades including a prerelease of ed25519-dalek which would actually make a crate prerelease of yubihsm possible. Pardon our dust.

Nah, don't worry. I'm very happy with this crate and rust crates too. I just report issues when I'm out of options 😅

In the meantime please upgrade to ecdsa v0.17.0-rc.5

The issue is I'm not using that explicitly and just assume it's due to rpgp pulling it with a different version (I'll test @baloo's PR there tomorrow).

So, thanks for your hard work. I really appreciate it 🙇 (the mockhsm feature here is extremely useful, Yubico should pay you your weight in gold 🥇).

Have a nice evening! 👋