Skip to content

fix(ios): remove Cordova.framework from Capacitor project #8524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcesarmobile wants to merge 3 commits into
base: next
Choose a base branch
from
+41 −38
Open

fix(ios): remove Cordova.framework from Capacitor project #8524

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5bb94a
fix(ios): remove Cordova.framework from Capacitor project
jcesarmobile Jul 6, 2026
f113c42
remove more Cordova.framework references and reference Capacitor.fram…
jcesarmobile Jul 7, 2026
9880ccb
update capacitor cordova build command
jcesarmobile Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ios/Capacitor/Capacitor.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@
62959B452524DA7800A3D7F1 /* CAPPlugin.h in Headers */ = {isa = PBXBuildFile; fileRef = 62959B132524DA7700A3D7F1 /* CAPPlugin.h */; settings = {ATTRIBUTES = (Public, ); }; };
62959B462524DA7800A3D7F1 /* CAPBridge.swift in Sources */ = {isa = PBXBuildFile; fileRef = 62959B142524DA7700A3D7F1 /* CAPBridge.swift */; };
62959B472524DA7800A3D7F1 /* CAPNotifications.swift in Sources */ = {isa = PBXBuildFile; fileRef = 62959B152524DA7700A3D7F1 /* CAPNotifications.swift */; };
62959BA52526475A00A3D7F1 /* Cordova.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 62959BA02526474300A3D7F1 /* Cordova.framework */; };

@OS-pedrogustavobilro OS-pedrogustavobilro Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of this change, the capacitor-swift-pm xcframework build, as it stands now, will fail for Cap 9.

The build-cap command Capacitor workspace and then generates Capacitor and Cordova xcframeworks from it, but the Cordova build directory will not be found anymore. I tested it on a fork using this branch and it failed for that reason - error: the path does not point to a valid framework: /Users/runner/work/capacitor-swift-pm/capacitor-swift-pm/capacitor-checkout/ios/Capacitor/Build/iOS-Simulator.xcarchive/Products/Library/Frameworks/Cordova.framework.

With some elbow grease from Claude I managed to get a working version in my fork with which I could at least test, but essentially this means either:

  1. We fix the capacitor-swift-pm build to differ for 9.X versions .
  2. Or we remove the xcframework build logic altogether for Cap 9, keeping in mind it still needs to exist for Cap 8.

Which probably warrants re-discussion internally with the team again, just wanted to bring it up.

@jcesarmobile jcesarmobile Jul 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've referenced Capacitor.framework in the CapacitorCordova project, since now its needed, not sure if that could fix the issue or break it more.

Also linked the Plugin.swift in the CapacitorCordova project since that wasn't done, so it wasn't part of the SPM project.

@OS-pedrogustavobilro OS-pedrogustavobilro Jul 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Re-approved

I've referenced Capacitor.framework in the CapacitorCordova project, since now its needed, not sure if that could fix the issue or break it more.

Uhh I don't think it would fix the issue I referred to in capacitor-swift-pm no, but still makes sense.

@jcesarmobile jcesarmobile Jul 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yeah, didn't notice we are only building Capacitor scheme, and Cordova scheme was being built since it was a dependency of Capacitor scheme.

We can probably change capacitor-swift-pm to build Cordova scheme now instead of Capacitor scheme since I made Capacitor a dependency, would be simpler than your changes, but would still need to be conditional for using Cordova in 9.x and Capacitor in previous versions.

@OS-pedrogustavobilro OS-pedrogustavobilro Jul 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

6296A77E253A2E49005A202A /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6296A77D253A2E49005A202A /* AppDelegate.swift */; };
6296A782253A2E49005A202A /* ViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6296A781253A2E49005A202A /* ViewController.swift */; };
6296A785253A2E49005A202A /* Main.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 6296A783253A2E49005A202A /* Main.storyboard */; };
Expand Down Expand Up @@ -264,7 +263,6 @@
buildActionMask = 2147483647;
files = (
501CBAA71FC0A723009B0D4D /* WebKit.framework in Frameworks */,
62959BA52526475A00A3D7F1 /* Cordova.framework in Frameworks */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down
Loading