Fix test result ordering by test timestamps - #12533
Open
jayasree-007 wants to merge 4 commits into
Open
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
SchrodingersGat
approved these changes
Aug 1, 2026
SchrodingersGat
added
bug
| ? new Date(b.finished_datetime).getTime() | ||
| : null; | ||
|
|
||
| if (finishedA !== finishedB) { |
Member
There was a problem hiding this comment.
Perhaps this repeated comparison pattern could be refactored into a helper? It's repeated three times here, and three times again in the other file
Author
There was a problem hiding this comment.
Thanks for the suggestion. I've refactored the comparison logic into a shared helper and updated both BuildOutputTable and StockItemTestResultTable to use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the default ordering of
StockItemTestResultto prioritize:finished_datetimestarted_datetimedatepkIt also updates the frontend ordering in
StockItemTestResultTableandBuildOutputTableso the displayed "latest" test result follows the same ordering logic.Fixes #12509