Update dependency svgo to v4.0.2 [SECURITY]#1574
Open
renovate[bot] wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1574 +/- ##
=======================================
Coverage 63.64% 63.64%
=======================================
Files 68 68
Lines 6206 6206
Branches 1378 1378
=======================================
Hits 3950 3950
Misses 2217 2217
Partials 39 39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.0.1→4.0.2SVGO removeScripts plugin leaves some executable scripts intact
GHSA-2p49-hgcm-8545
More information
Details
Summary
SVGO's removeScripts plugin (disabled by default) removes scripts from the SVG, however executable scripts were left intact in some cases. If a consumer relied on this plugin for sanitization and served them to users, these SVGs could open up doors to XSS.
Details
SVGO has a plugin for removing scripts from an SVG, which removes:
<script>elementson…event handlers (v4 and v3 only)While SVGO is not a sanitization library, SVGO continues to maintain the plugin for those already using it for this purpose.
However, there were two problems:
scriptelements, for example if one declared an explicit prefix for the SVG namespace (<svg:script>) instead of using the default namespace (<script>), the<svg:script>tag would be left intact.Proof of Concept
Impact
If you run SVGO on untrusted input (e.g., user uploads to a web application) and you depended on removeScripts, then some scripts may still be present. If that SVG was then opened directly by another user on the same domain, it could invoke scripts that could read local storage or cookies.
This may affect you if you have enabled one of the following:
It's unlikely to impact users who just use SVGO locally on their own SVGs or in build pipelines.
Patches
>= 3.0.0, <= 4.0.1
SVGO patched v4.0.2 and v3.3.4. Just upgrade the dependency using your preferred package manager! For example:
yarn up svgo ##### or if SVGO is a nested dependency yarn up -R svgoThe proposed fix is to improve our namespace-aware handling to explicitly act on the default namespace, SVG namespace, and XHTML namespace only. This handles all scripts that are executed by browsers, but will leave intact custom prefixes that happen to have an element called
<*:script>which clients shouldn't treat as executable.>= 2.0.0, <= 2.8.2
SVGO patched v2.8.3, however SVGO v2 explicitly only implements and documents that it will remove
<script>elements and nothing more. It has the namespace aware handling for tags like<svg:script>or<xhtml:script>, but has not been updated to remove JavaScript URIs or event handlers like >= v3. If this is something you need, please upgrade to v4 or v3, or reach for one of the documented workarounds at the end.>= 1.0.0, <= 1.3.2
SVGO v1 has been deprecated for a while now and won't be patched. Please upgrade to a more recent version! If something is preventing you from doing so, please reach out! We're happy to expand our migration guides or support you if you're having trouble.
Workarounds
If your motivation for enabling the plugin is SVG sanitization, consider reaching for a dedicated SVG sanitization tool and invoke it before passing the SVG to SVGO.
Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:H/I:L/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
svg/svgo (svgo)
v4.0.2Compare Source
What's Changed
Security
<script>handling namespace aware. By @SethFalcoBug Fixes
tcommands. By @KTibow in #2156Performance
Other Changes
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.