Skip to content

Convert iframe plugin to class-based registration pattern#1572

Merged
cdrini merged 1 commit into
internetarchive:masterfrom
cdrini:refactor/iframe-plugin-registration
Jul 22, 2026
Merged

Convert iframe plugin to class-based registration pattern#1572
cdrini merged 1 commit into
internetarchive:masterfrom
cdrini:refactor/iframe-plugin-registration

Conversation

@cdrini

@cdrini cdrini commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Co-Authored-By: Drini Cami <cdrini@gmail.com>
@cdrini

cdrini commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Auto-merging, small refactor.

@cdrini
cdrini merged commit 172ce56 into internetarchive:master Jul 22, 2026
11 of 12 checks passed
@cdrini
cdrini deleted the refactor/iframe-plugin-registration branch July 22, 2026 18:50
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.64%. Comparing base (44d6d54) to head (019e2b1).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/plugins/plugin.iframe.js 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1572      +/-   ##
==========================================
+ Coverage   63.61%   63.64%   +0.03%     
==========================================
  Files          68       68              
  Lines        6206     6206              
  Branches     1378     1378              
==========================================
+ Hits         3948     3950       +2     
+ Misses       2219     2217       -2     
  Partials       39       39              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants