BR auto-hiding chrome#1571
Open
cdrini wants to merge 16 commits into
Open
Conversation
cdrini
force-pushed
the
feature/hideable-chrome2
branch
from
July 23, 2026 16:18
d3a5805 to
5a1ea9d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1571 +/- ##
==========================================
- Coverage 63.64% 62.15% -1.50%
==========================================
Files 68 69 +1
Lines 6206 6373 +167
Branches 1378 1416 +38
==========================================
+ Hits 3950 3961 +11
- Misses 2217 2373 +156
Partials 39 39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Drini Cami <cdrini@gmail.com>
- Put the explicit down arrow behind an experiment option - Fix "canceling" show after starting to scroll up - Remove some unused code - Fix some type errors Co-Authored-By: Drini Cami <cdrini@gmail.com>
Co-Authored-By: Drini Cami <cdrini@gmail.com>
cdrini
force-pushed
the
feature/hideable-chrome2
branch
from
July 23, 2026 16:28
5a1ea9d to
9d6ecbc
Compare
cdrini
marked this pull request as ready for review
July 23, 2026 16:31
…Fader Co-Authored-By: Drini Cami <cdrini@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the chrome auto-hide when the user is in fullscreen. Specifically:
The chrome hides if:
And shows if:
QA/test: https://deploy-preview-1571--ia-bookreader.netlify.app/bookreaderdemo/demo-internetarchive?ocaid=theworksofplato01platiala (be sure to go fullscreen)