Skip to content

Change context menu to horizontal layout#1564

Merged
cdrini merged 3 commits into
internetarchive:masterfrom
schu96:horizontal-context-menu
Jul 15, 2026
Merged

Change context menu to horizontal layout#1564
cdrini merged 3 commits into
internetarchive:masterfrom
schu96:horizontal-context-menu

Conversation

@schu96

@schu96 schu96 commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Added some CSS styling changes to change the alignment from vertical to horizontal layout for highlight menu. Includes a new ... menu option that changes the options for potential features

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.61%. Comparing base (6ec67ce) to head (9873bfa).

Files with missing lines Patch % Lines
src/util/TextSelectionManager.js 5.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1564      +/-   ##
==========================================
- Coverage   63.75%   63.61%   -0.14%     
==========================================
  Files          68       68              
  Lines        6191     6206      +15     
  Branches     1375     1378       +3     
==========================================
+ Hits         3947     3948       +1     
- Misses       2205     2219      +14     
  Partials       39       39              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@schu96
schu96 force-pushed the horizontal-context-menu branch from 838f48d to b131394 Compare July 13, 2026 20:29
Add new package to dependency list
@schu96
schu96 force-pushed the horizontal-context-menu branch 2 times, most recently from 07ebad6 to 8c4f31c Compare July 15, 2026 21:28

@cdrini cdrini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! One question on whether we want to show the text by default on desktop, but I think it's good as-is.

@schu96
schu96 force-pushed the horizontal-context-menu branch from 8c4f31c to 9873bfa Compare July 15, 2026 21:30
@cdrini
cdrini merged commit 44d6d54 into internetarchive:master Jul 15, 2026
8 of 10 checks passed
jbuckner added a commit that referenced this pull request Jul 23, 2026
…-carets

* origin/master: (90 commits)
  Convert iframe plugin to class-based registration pattern
  Change context menu to horizontal layout + add "more" menu (#1564)
  5.0.0-116
  Add minimum release age to renovate.json
  Pin eslint version in renovate to v7
  Group renovate deps to have fewer noisy PRs
  Small TS fixes
  Add CLAUDE.local.md to .gitignore
  Consolidate generator utils into src/util/generators.js
  Fix text fragment but if words were a sole delimiter character
  Make getBoundaryPointAtIndex handle commas being replaced during normalization
  Make Copy Link to Highlight links more reslient to url encoding
  feat: open search panel on load when ?focus=search (#1550)
  5.0.0-115
  Update IA deps
  Update dev dependencies
  Update build dependencies
  update test deps
  Fix clicking copy link to highlight clears selection on iOS
  Have br-menu-select fade-in
  ...

# Conflicts:
#	package-lock.json
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants