Force Vpp composition when video count more than plane count - #524
Conversation
|
Do not merge |
|
@harishkrupo |
|
@Shao-Feng |
|
@js0701 @Shao-Feng |
sysopenci
left a comment
sysopenci
left a comment
There was a problem hiding this comment.
Autobuild started from pull-request-changes on this PR.
FAILURE: CheckBug Bad comments/Bugs
For more information, see: /absp/builders/celadon-autobuild/builds/191
|
@harishkrupo I rebased and use your commit in PR467 in here |
sysopenci
left a comment
sysopenci
left a comment
There was a problem hiding this comment.
Autobuild started from pull-request-changes on this PR.
FAILURE: CheckBug Bad comments/Bugs
For more information, see: /absp/builders/celadon-autobuild/builds/207
Sure. Thanks :) |
In cases where we fail to dedicate a separate plane for protected
content, say we have only one HW plane, the layers must be
composed using VAAPI as Mesa doesn't support composition of protected
content.
Jira: None
Test: When we have only one plane for display, all the contents are properly
rendered.
Change-Id: I56da9b478a614d4f8c6746d8995ae7f3146b26ac
Signed-off-by: Harish Krupo <harish.krupo.kps@intel.com>
Signed-off-by: Johnson Lin <johnson.lin@intel.com>
Conflicts:
common/compositor/va/varenderer.cpp
|
@Shao-Feng @harishkrupo |
This scenario is true when ACRN only assign 1 plane to Andriod Then VPP should be used for composition due to 2 reasons 1: If video is protected, 3D patch can't not deal with it 2: Some video effect still wanted on the video layer Change-Id: I892fef1f13cd4e2b7665b2d5edb7c0203faf118a Tracked-On: None Tests: Android UI normal Signed-off-by: Lin Johnson <johnson.lin@intel.com>
For the multiple layer case, we need to use UI formats to prevent any artifacts Change-Id: I9d5d1f87b9d432f6a1a80d3eac05a6e3e580f5dd Tracked-On: None Tests: Android UI be compositioned well Signed-off-by: Lin Johnson <johnson.lin@intel.com>
1) overlay plane not universal can't be count as avail planes for video 2) VPP can't deal with solid color(no input buffer), drop solid color layer for temp solution 3) Video Planes don't have to only contain 1 layer(ResetLayers) Change-Id: Ie2b285598ea77bd1038b1dfe5d630cf7bf1aa816 Tracked-On: None Tests: Android video playback with UI composited by VPP path Signed-off-by: Lin Johnson <johnson.lin@intel.com>
WA for VPP linux compiling error Change-Id: Ibf5363ac15abdbdf2705363ea7d7913ab26d231a Tracked-On: None Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
|
Look Good to me |
4 participants
This scenario is true when ACRN only assign 1 plane to Andriod
Then VPP should be used for composition due to 2 reasons
1: If video is protected, 3D patch can't not deal with it
2: Some video effect still wanted on the video layer
Change-Id: I892fef1f13cd4e2b7665b2d5edb7c0203faf118a
Tracked-On: None
Tests: Android UI normal
Signed-off-by: Lin Johnson johnson.lin@intel.com