Add grader field to GraphQL Submission Type - #2661
Open
Tom-Powles wants to merge 1 commit into
Open
Conversation
Extend submission GraphQL schema with additional grader field. Brings GraphQL into parity with REST API (which includes grader_id in submission object responses). Increases usefulness of submission data in GraphQL API by reducing need to cross-reference grader data via additional queries, decreasing total number of queries and data over fetching. Test plan * Create a Course with an assignment * Assign a teacher and a student * Submit as the student and mark as the teacher * Re-submit as the student and mark as the teacher * Navigate to /graphiql * Run a query retrieving nodes from submissionsConnection and submissionsHistoryConnection * Check the grader fields appear in nodes from both and has expected User fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend submission GraphQL schema with additional grader field. Brings GraphQL into parity with REST API (which includes grader_id in submission object responses). Increases usefulness of submission data in GraphQL API by reducing need to cross-reference grader data via additional queries, decreasing total number of queries and data over fetching.
Test plan