Assignments copied between courses now default to unpublished - #2620
Open
hergin wants to merge 1 commit into
Open
Assignments copied between courses now default to unpublished#2620hergin wants to merge 1 commit into
hergin wants to merge 1 commit into
Conversation
When copying an assignment from one course to another, the copied assignment was automatically published in the new course. This change makes copied assignments default to an unpublished state instead, giving instructors a chance to review the assignment before it becomes available to students. If an assignment's workflow state is explicitly set in the source course, that state is preserved during the copy. Test Plan: - Create a published assignment in a source course - Copy the course to a new course - Verify the copied assignment is unpublished in the new course - Verify that if an unpublished assignment is copied, it remains unpublished
|
|
Author
|
Why is this still pending? @spencerolson |
udengwusomtochukwu
added a commit
to udengwusomtochukwu/canvas-lms
that referenced
this pull request
Jul 2, 2026
Adapted from upstream PR instructure#2620, which changes the importer's fallback default (hash[:workflow_state] || 'unpublished'). That fallback never fires for Canvas course copy — the cartridge exporter always writes workflow_state and the converter always reads it back — so the PR as written is a no-op for its stated case (verified empirically on a running instance; its spec was never run by upstream CI). Instead, scope the rule to the course_copy_importer migration type: copied assignments arrive unpublished so teachers review them before students can see them. Classic-quiz assignment shells are excluded (their state follows the quiz), and blueprint syncs and cartridge imports keep upstream behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When copying an assignment from one course to another, the copied assignment was automatically published in the new course. This change makes copied assignments default to an unpublished state instead, giving instructors a chance to review the assignment before it becomes available to students. If an assignment's workflow state is explicitly set in the source course, that state is preserved during the copy.
Test Plan: