Skip to content

Allow time tag to retain 'datetime' attribute in RCE #2532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seanbeirnes wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −2
Open

Allow time tag to retain 'datetime' attribute in RCE #2532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gems/canvas_sanitize/lib/canvas_sanitize/canvas_sanitize.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ def self.included(klass)
"mozallowfullscreen"].freeze,
"ol" => ["start", "type"].freeze,
"q" => ["cite"].freeze,
"time" => ["datetime"].freeze,
"table" => %w[summary width border cellpadding cellspacing center frame rules].freeze,
"tr" => %w[align valign dir].freeze,
"td" => %w[abbr axis colspan rowspan width align valign dir].freeze,
Expand Down
6 changes: 6 additions & 0 deletions gems/canvas_sanitize/spec/canvas_sanitize/canvas_sanitize_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,12 @@
expect(res).to eq str
end

it "keeps datetime attribute only on time tags" do
str = %(<div style="color: red;" datetime="2025-06-15">June 15, 2025</div><span datetime="2025-06-15">June 15, 2025</span><time datetime="2025-06-15">June 15, 2025</time>)
res = Sanitize.clean(str, CanvasSanitize::SANITIZE)
expect(res).to eq %(<div style="color: red;">June 15, 2025</div><span>June 15, 2025</span><time datetime="2025-06-15">June 15, 2025</time>)
end

Dir.glob(File.expand_path(File.join(__FILE__, "..", "..", "fixtures", "xss", "*.xss"))) do |filename|
name = File.split(filename).last
it "sanitizes xss attempts for #{name}" do
Expand Down
2 changes: 1 addition & 1 deletion packages/canvas-rce/src/__tests__/defaultTinymceConfig.test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/canvas-rce/src/defaultTinymceConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ const defaultTinymceConfig = {
nav: [],
section: [],
summary: [],
time: [],
time: ['datetime'],
}),

extended_valid_elements: elemsToTinyStringConfig({
Expand Down
Loading