cache_elem_data() if needed in surface remesher - #33346
Merged
Merged
Conversation
The existing code here isn't actually going to output wrong results (those Modification calls are invalidating cached spatial dimension but only querying cached subdomains), but it's interfering with my attempts to fix a couple libMesh preparation bugs in libMesh/libmesh#4435 Refs idaholab#32398
loganharbour
approved these changes
Jul 15, 2026
Contributor
|
Job Test, step Results summary on e52ae48 wanted to post the following: Framework test summaryCompared against 39a256e in job civet.inl.gov/job/3974625. No change Modules test summaryCompared against 39a256e in job civet.inl.gov/job/3974625. No change |
GiudGiud
approved these changes
Jul 15, 2026
Contributor
|
Job Documentation, step Docs: sync website on e52ae48 wanted to post the following: View the site here This comment will be updated on new commits. |
Contributor
|
test failures unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing code here isn't actually going to output wrong results (those Modification calls are invalidating cached spatial dimension but only querying cached subdomains), but it's interfering with my attempts to fix a couple libMesh preparation bugs in
libMesh/libmesh#4435
Refs #32398
Reason
We're keeping track of "cached element data" preparation in one bool, for forwards compatibility and to keep the updates inside a single element loop, but that means we can't go perfectly fine-grained with preparation aspects, so for safety we have to rebuild all element data caches whenever one of them gets invalidated. I'm trying to make sure MeshTools::Modification marks caches invalid whenever they might be, and to assert that we only query caches if they're marked valid, but the extra safety requires an extra rebuild here.
Design
Rebuild cached data (including subdomain sets) if needed.
Impact
No API changes.
No effect at all before libMesh/libmesh#4435 gets merged. After that merge there'll be a tiny slowdown, one extra element loop in this mesh generator.