-
Notifications
You must be signed in to change notification settings - Fork 13
Generate a returns doc comment for cs::encodedReturn service operations #4932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bernardnormier
merged 3 commits into
icerpc:main
from
bernardnormier:encoded-return-doc-comment
Sep 13, 2026
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
66ce188
Generate a returns doc comment for cs::encodedReturn service operations
bernardnormier 678b20f
Always list the streamed return and add doc comment tests
bernardnormier d8fa9a6
Merge remote-tracking branch 'origin/main' into encoded-return-doc-co…
bernardnormier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,6 +52,17 @@ interface MySessionManager { | |
|
|
||
| /// Retrieves the {@link UserList} containing the names of the active users. | ||
| getActiveUsers() -> UserList | ||
|
|
||
| /// Retrieves the log of the given user. | ||
| /// @param user: The user. | ||
| /// @returns: The log entries. | ||
| [cs::encodedReturn] getLog(user: string) -> Sequence<string> | ||
|
|
||
| /// Streams the log of the given user. | ||
| /// @param user: The user. | ||
| /// @returns count: The number of entries. | ||
| /// @returns entries: The log entries. | ||
| [cs::encodedReturn] streamLog(user: string) -> (count: int32, entries: stream string) | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added XML documentation tests for both operations in 678b20f. |
||
| } | ||
|
|
||
| /// This summary comment includes special XML characters like < > & ' ", which should be properly escaped by | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the case where the user hasn't documented their
streamparameter, this will generate a doc-comment describing a tuple of one element, which is better than the current state, but feels incomplete.Maybe we could add a fallback for when
FormatOverviewreturns null, so we always generate 2 items in the list?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 678b20f: the stream item is always listed, with "The streamed return value." when it has no
@returns.